From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98525 invoked by alias); 10 Jan 2020 14:42:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98413 invoked by uid 89); 10 Jan 2020 14:42:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2020 14:42:01 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id E06383A0A for ; Fri, 10 Jan 2020 08:40:48 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id pvSyi2MlSHunhpvSyiBe7Y; Fri, 10 Jan 2020 08:40:48 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7vseeKmZ1M59xC+jySOalk36TEoW/uj7o92kexAW8vI=; b=vU9XuVy1uSrr5HMTDo+tiLUvcA LX+IHmbD3kXYjRjb8Oxw0SYLFzGvQtYK6OL2A1jD/RdZP9GCmJMkSzV4FGxfVFcGkI9vlL6L7dmuL D4RJONf+L7ETnGw9qPcLf1mAL; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:36114 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ipvSx-002AdY-U7; Fri, 10 Jan 2020 07:40:47 -0700 From: Tom Tromey To: Pedro Alves Cc: Shahab Vahedi , gdb-patches@sourceware.org, Shahab Vahedi , Andrew Burgess , Tom Tromey , Claudiu Zissulescu , Francois Bedard Subject: Re: [PATCH] Don't let TUI exceptions escape to readline (PR tui/9765) References: <20200110115728.13940-1-shahab.vahedi@gmail.com> <8f3c2363-6ab8-ce73-0f4b-b0b9efca6815@redhat.com> Date: Fri, 10 Jan 2020 14:42:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 10 Jan 2020 13:36:58 +0000") Message-ID: <87eew7wf0w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00252.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> gdb/ChangeLog: Pedro> yyyy-mm-dd Pedro Alves Pedro> PR tui/9765 Pedro> * tui/tui-io.c (tui_getc): Rename to ... Pedro> (tui_getc_1): ... this. Pedro> (tui_get): New, reimplent as try/catch wrapper around tui_getc_1. Pedro> --- Pedro> gdb/tui/tui-io.c | 31 ++++++++++++++++++++++++++++--- Pedro> 1 file changed, 28 insertions(+), 3 deletions(-) This seems like a good idea measure to me. Ideally I suppose these TUI functions shouldn't throw. However, in gdb it can be difficult to ensure that, so this provides some defense. thanks, Tom