From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58364 invoked by alias); 22 Feb 2020 00:44:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58356 invoked by uid 89); 22 Feb 2020 00:44:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.50.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Feb 2020 00:44:44 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 79EC3400D6991 for ; Fri, 21 Feb 2020 17:30:37 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 5IuQjbqjiRP4z5IuQj1cfO; Fri, 21 Feb 2020 18:44:42 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bxL2gJnVCHT1MDq9XT8xeg1VzYfS52o6cp0W+b+5XeY=; b=eaL2Xqz+j9k3dU+EIm244WRs1d xTL2R1/5z7PwXUMDagT5uyCcA8v82eMMCToNhfQL7JkFniTNUOhLbXMv1ylQ4drT7PmkYHQfAaDaZ Fmv3Tc+gyzM1xJjxluCrGJxy1; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:53980 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j5IuQ-001uux-Kt; Fri, 21 Feb 2020 17:44:42 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 03/14] Introduce dwarf2_per_objfile::obstack References: <20200215165444.32653-1-tom@tromey.com> <20200215165444.32653-4-tom@tromey.com> Date: Sat, 22 Feb 2020 00:44:00 -0000 In-Reply-To: (Simon Marchi's message of "Tue, 18 Feb 2020 23:13:21 -0500") Message-ID: <87eeun78na.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00875.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> + struct dwarf2_per_objfile *dwarf2_per_objfile >> + = get_dwarf2_per_objfile (objfile); >> + qfn->real_names = OBSTACK_CALLOC (&dwarf2_per_objfile->obstack, >> + qfn->num_file_names, const char *); >> + } Simon> The callers of dw2_get_real_path should be able to pass the dwarf2_per_objfile directly, Simon> instead of the objfile, simplifying this. Indeed. I made this change. Tom