Re: [PATCH][gdb] Expand symbolless symtabs using maint expand-symtabs

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> When trying to expand the partial symtab for hello.h:
Tom> ...
Tom> $ gdb -batch \
Tom>   -iex "set language c" \
Tom>   a.out \
Tom>   -ex "maint expand-symtabs hello.h" \
Tom>   -ex "maint info psymtabs"
Tom> ...
Tom> we in fact find that the partial symtab has not been expanded:
Tom> ...
Tom>   { psymtab hello.h ((struct partial_symtab *) 0x27cf070)
Tom>     readin no
Tom> ...

Does this matter, though?
I thought include psymtabs like these were kind of placeholders.

Tom> Fix this by passing a NULL symbol_matcher and lookup_name to
Tom> expand_symtabs_matching in maintenance_expand_symtabs, and skipping the call
Tom> to recursively_search_psymtabs if symbol_matcher == NULL and
Tom> lookup_name == NULL.

Could this code use map_symtabs_matching_filename instead?

I guess I'm not super fond of turning the reference arguments to
pointers, unless there's really no other way.

Tom