From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id g+YiMUANil/LcgAAWB0awg (envelope-from ) for ; Fri, 16 Oct 2020 17:14:40 -0400 Received: by simark.ca (Postfix, from userid 112) id BB6181EF6F; Fri, 16 Oct 2020 17:14:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EBD021E58E for ; Fri, 16 Oct 2020 17:14:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4569C3857C6C; Fri, 16 Oct 2020 20:38:40 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.228]) by sourceware.org (Postfix) with ESMTPS id 5983B3857C6C for ; Fri, 16 Oct 2020 20:38:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5983B3857C6C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id A3C5A14421 for ; Fri, 16 Oct 2020 15:38:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id TWUmk3fNun9FWTWUmkqKRZ; Fri, 16 Oct 2020 15:38:36 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mnTcBOT58yI6v7nbElLV1mR95WvJLtC3unpUGx6MN7s=; b=txPh4aTNr1sossMa/KmxMx5zdr CctVcBF+Njl06mk3GlhdVlnUYV5P25QYi6dooaowo1QYpRA3P2OCyvjwhgDhU7QqfUAnFup5EBu9S JrpSXfRQ9gwIrQ7Wdbmg2PG6J; Received: from 75-166-102-113.hlrn.qwest.net ([75.166.102.113]:44452 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kTWUm-002oJT-C2; Fri, 16 Oct 2020 14:38:36 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [PATCH][gdb/symtab] Handle setting line bp without debug line info References: <20201016140006.GA22271@delia> X-Attribution: Tom Date: Fri, 16 Oct 2020 14:38:35 -0600 In-Reply-To: <20201016140006.GA22271@delia> (Tom de Vries's message of "Fri, 16 Oct 2020 16:00:07 +0200") Message-ID: <87eelxoqic.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.102.113 X-Source-L: No X-Exim-ID: 1kTWUm-002oJT-C2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-102-113.hlrn.qwest.net (murgatroyd) [75.166.102.113]:44452 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> When setting a breakpoint on a line in an executable without debug line info, Tom> we run into an abort. I guess the idea is that there is some debug info but somehow the line numbers are missing? Tom> + /* We couldn't find the location of `main', possibly due to missing Tom> + line number info, fall back to line 1 in the corresponding file. */ Tom> + loc->set (symbol_symtab (bsym.symbol), 1); ... which is why the symbol and symtab are set but the line number is not. The patch seems fine to me. In general it seems to me that it's ok to work around pathological / broken cases like this when possible, even if the results aren't perfect. Tom