From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CID9GqM+k2AxEgAAWB0awg (envelope-from ) for ; Wed, 05 May 2021 20:56:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 6CA5C1F11C; Wed, 5 May 2021 20:56:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CAF331E01F for ; Wed, 5 May 2021 20:56:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 073563857C44; Thu, 6 May 2021 00:56:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 073563857C44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620262562; bh=QCJnxBTPPA4OXzwnC2cA0W2aFZDPZypWTVLIpvusgRE=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RtgUrtsgwwyF4DG5IwWnPokGvZPuj0TZajz1fkr7tdq3WbQudcBiQWeKNBJO6z/SR 1HveriK79FaPwl06JnRihbRvU2iDdVW7TZ3bflaOPh+8sA09Rs2cUIgGOTJERllzFt Q5xUBWp6xPgXBmXAjU6Lwr6C9ehtZdnsHZ5o+RnU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id F3F493857C44 for ; Thu, 6 May 2021 00:55:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F3F493857C44 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-180-6GV_PIXiNrSJ1DMMJjOGmg-1; Wed, 05 May 2021 20:55:58 -0400 X-MC-Unique: 6GV_PIXiNrSJ1DMMJjOGmg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C7D8107ACF2; Thu, 6 May 2021 00:55:57 +0000 (UTC) Received: from redhat.com (ovpn-112-75.phx2.redhat.com [10.3.112.75]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01A7D5D6A8; Thu, 6 May 2021 00:55:57 +0000 (UTC) Received: from [127.0.0.1] (helo=vm-rhel7) by redhat.com with esmtp (Exim 4.94) (envelope-from ) id 1leSJ0-00084W-4T; Wed, 05 May 2021 20:55:55 -0400 To: tom@tromey.com Subject: Re: [PATCH] debuginfod-support.c: Use long-lived debuginfod_client References: <20210430235735.1371915-1-amerey@redhat.com> Date: Wed, 05 May 2021 20:55:52 -0400 In-Reply-To: <20210430235735.1371915-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Fri, 30 Apr 2021 19:57:35 -0400") Message-ID: <87eeek1y07.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Frank Ch. Eigler via Gdb-patches" Reply-To: "Frank Ch. Eigler" Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi - > Aaron> Instead of initializing a new debuginfod_client for each query, > Aaron> store the first initialized client for the remainder of the GDB > Aaron> session and use it for every debuginfod query. > Will this still work with existing versions of the library? Yes. > Aaron> +static debuginfod_client *global_client = nullptr; > Will there ever be a need to finalize this object? Like, shut it down > cleanly in some way? Nope (except perhaps if running gdb under valgrind?). - FChE