From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 77B3E3KEAWGtIgAAWB0awg (envelope-from ) for ; Wed, 28 Jul 2021 12:23:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 3F48D1EDFB; Wed, 28 Jul 2021 12:23:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A7D9E1E813 for ; Wed, 28 Jul 2021 12:23:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B3B41399E022 for ; Wed, 28 Jul 2021 16:23:12 +0000 (GMT) Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.49.124]) by sourceware.org (Postfix) with ESMTPS id 8EAB53888C7A for ; Wed, 28 Jul 2021 16:20:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8EAB53888C7A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id CD1C7AF62B for ; Wed, 28 Jul 2021 11:19:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8mDnmBGmLjSwz8mDnmspdo; Wed, 28 Jul 2021 11:15:51 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xgbyAWcO04vjJ2+LnqEsBUK5mhJtFhP0xSGVRf5r2Y4=; b=ZbwmefD/SY0hXAJm/tW/UKKe/f u1Hc9JZsAEHJFtfAU+4QaElGZv9GLtF4rfofXGmSDJzX4A44C0kFSsTyc+4ddObT44UXmocxpaWMf WoDnG4SYDRDJS81pxjyNXHXKo; Received: from 97-122-74-117.hlrn.qwest.net ([97.122.74.117]:34956 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m8mDn-00469U-4W; Wed, 28 Jul 2021 10:15:51 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [gdb/build] Fix Werror=nonnull-compare build breaker with gcc 12 References: <20210726211101.ivychvbfgaafxjtz@lug-owl.de> <20210727100354.GB4037238@embecosm.com> <20210727113511.GC4037238@embecosm.com> <6cf80ba9-b010-bb42-c92d-84e4f396813c@suse.de> X-Attribution: Tom Date: Wed, 28 Jul 2021 10:15:50 -0600 In-Reply-To: (Tom de Vries's message of "Tue, 27 Jul 2021 18:28:30 +0200") Message-ID: <87eebie7nt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.74.117 X-Source-L: No X-Exim-ID: 1m8mDn-00469U-4W X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-74-117.hlrn.qwest.net (murgatroyd) [97.122.74.117]:34956 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Tom> I managed now to reproduce, and wrote a patch along these lines. Tom> Any comments? Tom> In particular, any suggestion where to put ignore_nonnull? Tom> Or, is it perhaps a better idea to have a gdb_assert_nonnull and Tom> implement things there? How about we either drop the nonnull attribute or we use -fno-delete-null-pointer-checks? I personally feel that the gcc approach in this area is counter-productive, at least for our purposes. My view is that the point of this stuff is to help us detect programming errors -- and we're uninterested in using non-null-ness as some kind of optimization hint. gcc seems to want it both ways, which seems bizarre. But, given that this is how the compiler works, IMO we should choose reliability whichever way we best can. thanks, Tom