From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nBbCED8FDGZcRyAAWB0awg (envelope-from ) for ; Tue, 02 Apr 2024 09:16:47 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=uhhMOhou; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 229091E0C0; Tue, 2 Apr 2024 09:16:47 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D77641E030 for ; Tue, 2 Apr 2024 09:16:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1645B3858286 for ; Tue, 2 Apr 2024 13:16:44 +0000 (GMT) Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 4C5F23858C36 for ; Tue, 2 Apr 2024 13:16:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C5F23858C36 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4C5F23858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712063779; cv=none; b=e8X0zEbpeWR7RJ0v6FLPw3fFyVwxfN5BoTwWvR6Lp1bmcE3GPLdmEZTUH0g/p5sd1vNQkSwTUpKAKXZT2dvGnxPxLqt/gDOZ+POOM0Aaw8ggsEjf0uhSXAXtne92/tb/5p/fonyWiC43qD8iPHWLZdoGSL+UI98K5XmwLQ99HRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712063779; c=relaxed/simple; bh=DLXJJfcNb7Qh2VAgUMysfCGJPRBjIvhpx+aem4a3Hf8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dowlribWfxhQ2xEglhrCxDHoiOi5b6FLpI3GhBbvzWEVZV2UjXKCdIATsGgPUIvk1q7uc7NFJ6+cFV6fMB0RJ6WGd3NwcvsGk3pSB9eBtS+JU4KGMNbU5yDjsUhbpEaArsNYRAuFHPVdM0q/JGUrGnJirWSa4doukf8gC/lQTYo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5010a.ext.cloudfilter.net ([10.0.29.199]) by cmsmtp with ESMTPS id rK6Vr9WMeHXmArdzrrnnNa; Tue, 02 Apr 2024 13:16:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rdzprvvhzkyhrrdzqrOuYQ; Tue, 02 Apr 2024 13:16:14 +0000 X-Authority-Analysis: v=2.4 cv=Z9TqHmRA c=1 sm=1 tr=0 ts=660c051e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=zkFbtGESC73jI1oFWzYA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UgQtJMxgkAeS5Asch5HAhiw4cKM7dEysu6rGQGk8/WM=; b=uhhMOhouoLinaTPkbV6tPGq8LW pXWqMIjRNQ0CcsU7Vfhy7dWF02GdTfLYGGZOmRPGNkJXhjCmaWYJnVV8/cvAupf6P/2Xr+SJCW1xi CxfK2Sj7Xd1zOjOgat29ypL9x; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:58516 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rrdzp-000LBb-23; Tue, 02 Apr 2024 07:16:13 -0600 From: Tom Tromey To: "Six, Lancelot" Cc: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb: ensure has dwarf info before reading DWZ file References: <20240330110121.2292510-1-lancelot.six@amd.com> <87y19x9i9c.fsf@tromey.com> X-Attribution: Tom Date: Tue, 02 Apr 2024 07:16:12 -0600 In-Reply-To: (Lancelot Six's message of "Tue, 2 Apr 2024 08:40:25 +0000") Message-ID: <87edbnaorn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rrdzp-000LBb-23 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:58516 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfP9e8Hu5bzzSOGZk+U7MCVCBZyZl3KuZf/0bM8w9oACSVaRvweVa1zRm8kCQ+AvfqrexQcQuA46xOihFetytb9AruVPo/lY8fuR8WOKsvCzH60BhmZSd JzfTbCGj2JsBmZDBfNWI4dy9CQKoY1urXG8Ij01fXEl3DPwGFnfGk3g78l+1LvCwfCpgbUGdoUXptE8JJPK5m79nZNf96TmBZgg= X-Spam-Status: No, score=-3015.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > It can be called when doing "save gdb-index" (dwarf2/index-write.c: > save_gdb_index_command). This case is exercised by > "gdb.dwarf2/gdb-index-nodebug.exp". > Maybe a better approach could be to modify save_gdb_index_command to > check if there is any debug info before calling write_dwarf_index, but > the current try/catch approach is the construct currently taking core > of that. Having dwarf2_get_dwz_file return nullptr in that case does > made sense to me, but I can also go another direction. This seems fine, I don't think you need to change anything. Approved-By: Tom Tromey Tom