From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Jd2hNqf2R2gEMggAWB0awg (envelope-from ) for ; Tue, 10 Jun 2025 05:11:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=h3FKMEIU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C39EA1E11C; Tue, 10 Jun 2025 05:11:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DAD161E089 for ; Tue, 10 Jun 2025 05:11:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5FF91382D2AD for ; Tue, 10 Jun 2025 09:11:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5FF91382D2AD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=h3FKMEIU Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8315D382D2A2 for ; Tue, 10 Jun 2025 09:10:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8315D382D2A2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8315D382D2A2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749546625; cv=none; b=qLKWn7RqvxQh4TiSLRuLffiJqnkRS/A39zIQ2dpH0yj1rBRFd2OKXVkYpPjpLJvTF1M72I+OkvN/YtC0M8a/RBY0mbFQMvx9B7U6031ZYgSr1kgHdyvgvJg7BhoIkyn7SpFccbjI53izGgW5ub6ckZ3/TD1cPHTZ5RxPmkJuMj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749546625; c=relaxed/simple; bh=xK56Fd28pDDkBKGTJgUVnRmT9V67aw9/Ue/2GHePMb4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eLEXULwiGq3VoW75i4ehABZM0ue9jn7TQy9ES20bSX4R+2PqtkBxwWdWwVPkPrgbvIgxMAfsYvuXwspPI8R4BhsKpS+TKpYCPFA+Tr0gRp7OfPB8Ha/lndTKE1YL4YmjB7X8J/tcYa8Wg/ky5PEZPyrrgD5uTCP5Z/UZMCiTdEY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8315D382D2A2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749546625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hLhNEaBVAKrM7/Bpt3AxHum2sZMv+DKnu5TGiMHxO4w=; b=h3FKMEIUOMKa2CyLiTNlWNkvkDIms1hLn1P+YZwIhcUMxXLro0CCduHqtXgNNpNhKr9U2K ufWjJSRA2F0IvAF9nObxhokXWDOKS6lwsFZ4TjQ1XNXpRBOLFNEhyfu+z+s96Kv6uMlgKS iOSm0HD3Xjxd8Up5OHayg3cNiVVHNhc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-etHUhrcfMv6dWwTFicn1zw-1; Tue, 10 Jun 2025 05:10:24 -0400 X-MC-Unique: etHUhrcfMv6dWwTFicn1zw-1 X-Mimecast-MFC-AGG-ID: etHUhrcfMv6dWwTFicn1zw_1749546623 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f65a705dso3009046f8f.2 for ; Tue, 10 Jun 2025 02:10:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749546622; x=1750151422; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IfTf6E2Kavj3/fmVNP2SmRS93J5tITBC4O6/N4oQpYU=; b=U9c+09Hno5mndr+2eYGIK5iKXnPea3OwxZxi577Iqnus5ox+09QqViqb4tcrnhyjkT OV7RajRW+EwSW/8S+pC7SL2n8Fl48LGfx6jkeWJDrnKkFZJxgLLqE9XFu3dmoAM7prsN nQx+B+t5vQV9WhKqvBDH1kfyyHG7ZvNIGkmO7wyOhhZtsxpT9PD560ZOVbSVW3Y7tQPL dQ3YTMoWUBlwMY1pBjaF8coE1DD72uPTPbWJSJY/OYnSMWbFgjNWTMNqRIZrij1eG4/m oHqnAyHukOCFOfpyVlI63KW2iadrh2hLc/DlKRe7abbg/3gUvFvb5LNV30bxyudrpjL4 ppUA== X-Forwarded-Encrypted: i=1; AJvYcCW03HntXDGm+9eHcppN5i0cIPQo5ROLu2fT3of5fJvUh0GiBuuqElEdFSDQQYa+/oZlWIAmSiOO1dr/bA==@sourceware.org X-Gm-Message-State: AOJu0YwdANvSWfnd85XNBeqt3jYA08kPb3pfPl7EkmkgopMsTjZllC6+ rYw1t6rIusn9bTPuOWuQCsc7eu44MzYSaVlNY/RhHLJOji2AZ2AXcmU2uB3CAluby2aK8YsDQbr 0KZkNxliGGDgaqbMDTxaq/8llIa59yHEvS10JnIiMgCD/vDSjLoglFe66zzTjesjSPWnc8jQ= X-Gm-Gg: ASbGnctVHYMJ0k+Fdkt7F1Qcu+nQ5QjPB0ofy0xAHVkxDbPHPelZD/4QfSSsFyTpKLj OMYGAcmF19qhvYRrXVQ2rTbJ3dloBLJoysuoytm6HUYj7ylm3Z86w86KQM1PU35V3tvVlMYcVQR 1GSEQFFM8UwKJZSJcrzkEAYmbpqStCzVnzk2VNhXgdK70pMKUAwuWIHySXeGRZv0f7YgrtHQeAZ dSGhd5z9qFTO4AavDTMrOe95toeyfRuscovc/+OoeO+dvD3oi3YJpTAQHpxKV7GrL4UVJ6ONtXY 7L25md6P7Dh6U8NqUkRhxTJwKMt8iQ6mw6/cYftx/zhOZCs= X-Received: by 2002:a05:6000:420c:b0:3a4:ee3f:e9a6 with SMTP id ffacd0b85a97d-3a531ce7c2amr13077742f8f.54.1749546622136; Tue, 10 Jun 2025 02:10:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmDlA3XHDfwR9PxtoFr/D0LmmZpOcpEvE9vbFTr5tyjSjS2ex0DR2tNxWBOneS0DQHNFbavA== X-Received: by 2002:a05:6000:420c:b0:3a4:ee3f:e9a6 with SMTP id ffacd0b85a97d-3a531ce7c2amr13077722f8f.54.1749546621687; Tue, 10 Jun 2025 02:10:21 -0700 (PDT) Received: from localhost (75.226.159.143.dyn.plus.net. [143.159.226.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229de70sm11435142f8f.5.2025.06.10.02.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 02:10:21 -0700 (PDT) From: Andrew Burgess To: Fabian Kilger , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2][PR GDB/32956] gdb: query inferior's filesystem for build-id debug files In-Reply-To: <7cdc3a53-8d09-445f-a017-29084769fb76@sec.in.tum.de> References: <20250511150113.3163767-1-kilger@sec.in.tum.de> <20250511150113.3163767-3-kilger@sec.in.tum.de> <877c27i3zb.fsf@redhat.com> <7cdc3a53-8d09-445f-a017-29084769fb76@sec.in.tum.de> Date: Tue, 10 Jun 2025 10:10:19 +0100 Message-ID: <87ecvshshw.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Of-xwlvtCY0UD8vF-tlzMG9mJ78G7REelvAHNWVFYt4_1749546623 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Fabian Kilger writes: > Thanks for approving, I'll add the link to the commit message. > > If I merge this ahead of #1, can I leave it out in the v2 patch > submission, or should it be included for completeness' sake - not sure > what is desired. Sorry, have been side tracked on other tasks. I think you should merge this, and any new iteration would not include this patch as this would now be part of GDB. Thanks, Andrew > > Best, > Fabian > > On 5/23/25 20:20, Andrew Burgess wrote: >> Fabian Kilger writes: >>=20 >>> This fixes a bug related to build-id files with linux namespaces. >>> Specifically, we expect the debug files to be present inside the contai= ner, >>> thus the container filesystem should be queried if the program is runni= ng >>> inside one. >>=20 >> You should add a bug link to the end of this commit message, like: >>=20 >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D32956 >>=20 >> With that added, for this patch: >>=20 >> Approved-By: Andrew Burgess >>=20 >> You are welcome to merge this ahead of patch #1 if you want, as they are >> related, but don't depend on each other. >>=20 >> Thanks, >> Andrew >>=20 >>=20 >>=20 >>> >>> --- >>> gdb/build-id.c | 6 ++++-- >>> 1 file changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/gdb/build-id.c b/gdb/build-id.c >>> index 43a80dd3978..abbd65a7c12 100644 >>> --- a/gdb/build-id.c >>> +++ b/gdb/build-id.c >>> @@ -29,6 +29,7 @@ >>> #include "gdbsupport/scoped_fd.h" >>> #include "debuginfod-support.h" >>> #include "extension.h" >>> +#include "inferior.h" >>> =20 >>> /* See build-id.h. */ >>> =20 >>> @@ -128,7 +129,8 @@ build_id_to_debug_bfd_1 (const std::string &origina= l_link, >>> =09 if (supports_target_stat !=3D TRIBOOL_FALSE) >>> =09 { >>> =09 struct stat sb; >>> -=09 int res =3D target_fileio_stat (nullptr, link_on_target, &sb, >>> +=09 int res =3D target_fileio_stat (current_inferior (), >>> +=09=09=09=09=09 link_on_target, &sb, >>> =09=09=09=09=09 &target_errno); >>> =20 >>> =09 if (res !=3D 0 && target_errno !=3D FILEIO_ENOSYS) >>> @@ -157,7 +159,7 @@ build_id_to_debug_bfd_1 (const std::string &origina= l_link, >>> =09=09 the path doesn't exist, but we just assume that anything >>> =09=09 other than EINVAL indicates the path doesn't exist. */ >>> =09 std::optional link_target >>> -=09=09=3D target_fileio_readlink (nullptr, link_on_target, >>> +=09=09=3D target_fileio_readlink (current_inferior (), link_on_target, >>> =09=09=09=09=09 &target_errno); >>> =09 if (link_target.has_value () >>> =09=09 || target_errno =3D=3D FILEIO_EINVAL) >>> --=20 >>> 2.49.0 >>=20 > > --=20 > Fabian Kilger, M.Sc. > Wissenschaftlicher Mitarbeiter > > Technische Universit=C3=A4t M=C3=BCnchen > TUM School of Computation, Information and Technology > Chair of IT Security > > Boltzmannstra=C3=9Fe 3 > 85748 Garching (bei M=C3=BCnchen) > > Tel. +49 (0)89 289-18587 > Fax +49 (0)89 289-18579 > > kilger@sec.in.tum.de > www.sec.in.tum.de > -----BEGIN PGP PUBLIC KEY BLOCK----- > > xjMEYHltfxYJKwYBBAHaRw8BAQdA7mzpLUfZIcIiMjdx+GBa8RuqZdMp/MUEpu4P > DTb2YwXNJEZhYmlhbiBLaWxnZXIgPGtpbGdlckBzZWMuaW4udHVtLmRlPsKLBBMW > CAAzFiEETPRi+vRLaNymGJvYr2lqRpshfmkFAmB5bX8CGwMFCwkIBwIGFQgJCgsC > BRYCAwEAAAoJEK9pakabIX5pCzcA/ivCFRRbxJfpiwOzV5CvflcHPNN2LmCxSBlc > rBpliBhWAP43PcAtWheftijoLpcwy3nD0TVTDRrJY/hRkKDbvmrWCM44BGB5bX8S > CisGAQQBl1UBBQEBB0BtYlZed2qkwQWmV+MaUhC78XgZI0ezLuU2nr8bocqXCAMB > CAfCeAQYFggAIBYhBEz0Yvr0S2jcphib2K9pakabIX5pBQJgeW1/AhsMAAoJEK9p > akabIX5pUNQA/juajzwCYdtbo+sXQUlZufPiPwLiPr6LuJBNZwL6OlbmAQDvyu6h > +X9K2gzgLviiNEmcCAddwynvjXiLt3c+oir7AA=3D=3D > =3DVdeZ > -----END PGP PUBLIC KEY BLOCK-----