From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Z1xhNHOJ+2j3RAYAWB0awg (envelope-from ) for ; Fri, 24 Oct 2025 10:13:07 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ME4OcZxU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C12111E0BC; Fri, 24 Oct 2025 10:13:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B3AFB1E04C for ; Fri, 24 Oct 2025 10:13:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C77C3385801D for ; Fri, 24 Oct 2025 14:13:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C77C3385801D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ME4OcZxU Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id E06A63858286 for ; Fri, 24 Oct 2025 14:08:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E06A63858286 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E06A63858286 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761314938; cv=none; b=rFw5tgzqVV1NGlJkZKrqgpR4Bonvkd1oxSmlG51Lq//YhEw22Pq63K6FCNthWn9i+J1+uVXrvvwH6BJb3VnhCtFYFtF6AdmFtkjHQXwDJeXZtNC46s3a64kvkutwVqleIbDTKy7UzncdSzKyLjuWLq/ur6A3289zKTKw/mO0sD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761314938; c=relaxed/simple; bh=KcMpgIZnYhPtEXCQYjXhYdRvtMg9H8lRNbEIekAj4uw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ij7xH8ToFBj2Cs+6rSfkqkYqkqCX0Grj9eiQ/5C4Cz4+aHICekoi8j/P7pxshsq4aPNsfFUuac2ewWrTJy32wV2ZuIw19BDDkih5xcUqHSriNXAZ98g9kNs7SsekS/5bHzVI0QLnTvvDHZH8hogNsWRW5sFrRffNTEXfcFytR7w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E06A63858286 Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id CHStvw1jTv724CITRv27Hg; Fri, 24 Oct 2025 14:08:57 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id CITQvl0VFvrdzCITQvBfEg; Fri, 24 Oct 2025 14:08:57 +0000 X-Authority-Analysis: v=2.4 cv=d7f1yQjE c=1 sm=1 tr=0 ts=68fb8879 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=qySPx7JOIoJLSAS8p8cA:9 a=ZXulRonScM0A:10 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wxpaikQ+vYVZ6hLDqR61CtynVekLjpazGrAXRXToXDE=; b=ME4OcZxUM5AYEXZMiYkngDXRee uZjFEI1qoxF3fPqS3hS1XcB2bE+V+8BUC8hxf/+jiP7TJSloVWlure0eECi2CIS88z5KCY34tMEJn dJW9XSmd/BBnV8J8/z+prAzeQ; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:54988 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vCITQ-00000003wOU-1Lci; Fri, 24 Oct 2025 08:08:56 -0600 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Free multidicts from blockvector In-Reply-To: <873479bgdf.fsf@tromey.com> (Tom Tromey's message of "Thu, 23 Oct 2025 12:52:12 -0600") References: <20251023-mdict-free-v1-0-ad02b2bdd549@tromey.com> <20251023-mdict-free-v1-2-ad02b2bdd549@tromey.com> <873479bgdf.fsf@tromey.com> X-Attribution: Tom Date: Fri, 24 Oct 2025 08:08:55 -0600 Message-ID: <87ecqsie88.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1vCITQ-00000003wOU-1Lci X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:54988 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKHrq8ZrmOHsxE6jbpyXc8jsX6Lxvvn9O/IuIS9UIe6T8BJIEWpxU37NxM6uewfHlELgrHaFoKSKmXIoDbM7dEopKFYFD2LEZyqsiuqBkKqMvgUoicbZ Z3B3N3+6/HjgNGyufHpwKwCXF+AbqcxPVNhgxvYu4Ic5kcUa9gXwNkNWsFFfaUymMjmXyF4jeWEa2PXaSeHaLXVhJvBJQFu+fxw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon> Ideally it would be struct block's just to call that. You could add a Simon> destructor to struct block and call it explicitly here. It would be the Simon> same result, but would be more correct encapsulation-wise. But I guess Simon> this is fine too for the time being. Tom> Yeah. I have kind of an aversion to explicit destructor calls. Tom> Though maybe not for any good reason. I was thinking about this last night and realized there's a bigger issue, which is that blocks are allocated on an obstack: struct block : public allocate_on_obstack and block = new (&m_objfile->objfile_obstack) struct block; but allocate_on_obstack requires that the object be trivially destructible. Maybe this could be remedied by resurrecting Jan's obstack allocator; making an "obstack_ptr" class that explicitly calls the destructor but not 'delete'; and finally changing blockvector to hold these. Tom