From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +/9vMA7YHWkL3xMAWB0awg (envelope-from ) for ; Wed, 19 Nov 2025 09:45:34 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ThiOgrX+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B2E911E0B6; Wed, 19 Nov 2025 09:45:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 247801E048 for ; Wed, 19 Nov 2025 09:45:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE46F384A865 for ; Wed, 19 Nov 2025 14:45:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE46F384A865 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ThiOgrX+ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 15035385F019 for ; Wed, 19 Nov 2025 14:45:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15035385F019 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 15035385F019 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763563502; cv=none; b=RMQKlQDFAR8rpSUtk3a7lP7P2E1rus0ZqIOnFESFp7uaD5BZEIeBEFxoSnVxBY0P6JFdV7R2GTougMBKmBkMevWMGyb9GGTjk93sjC6ia8T/MJ+n5IBI/PuAmI7eHZ2WK5HHSpmYY21XHYLadXTBh36Pydin+p5cUqLqCrecHak= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763563502; c=relaxed/simple; bh=Dg/X7CzpQmruiRH8L2dJw2Pf7ArC2Q8XkkRRhsEcCWw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=m118TG597fQOz6FEj/AZ8XUiUxgieghiQOKrCfceYQW1iboq1fMJlb/vylXw8d++61Q1uL3YkC5zrWeyMXEDjBMY47WFuDc90nk1a7zsZENnjuNMmHt2Km+QE6bo0Fx75EFUmlVbtZX2X/oei6CUKVf7PP2btmuvepEysDeCBP8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15035385F019 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763563501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9gTzBrTs+m8IOZj+DeebdNnPcckwjuWmEWejwro/wkA=; b=ThiOgrX+2ln4yB8y8WjSpgn0l6yrQMS/NYnA7JJKyj6NV1PaE/PNF2BMjQLeHJPwj38wSi aLu5ZlkDNv5ky9rJcCNQfotMAXBTXdbE0KqA4QfxKiNoLKSeeFFUunCG2OdlbuMNPH821h wmT+bPxgDzeeSrNmvoktghbEvEq5fy4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-ks2t-DabPhSebbbRfUJHBA-1; Wed, 19 Nov 2025 09:45:00 -0500 X-MC-Unique: ks2t-DabPhSebbbRfUJHBA-1 X-Mimecast-MFC-AGG-ID: ks2t-DabPhSebbbRfUJHBA_1763563500 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4779edba8f3so25525195e9.3 for ; Wed, 19 Nov 2025 06:45:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763563499; x=1764168299; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9gTzBrTs+m8IOZj+DeebdNnPcckwjuWmEWejwro/wkA=; b=dV3ZrgSehgFUsQfQ8rqcgjNyhbhzGWQe7oD+cjoFIV4rgb+ZzaED12wb/QEV8FvW9f cZvw+826VUzXHCcwGB4mu9XSCh7iyG8suwfnKP4knv8xh5AgUQziX5fzJWux8pnxsBmq HmBvf8UHxaiA+LUrDm1xmhYI/QqVzDZDQDfEwy9isFMedHl9yOk+LY9cFgbGAByJOHQE AYNSQ/+NT1+EQNREbCkGs3qOANThOnDGk2Ip6VPGensR2Mtvr4qnng58B7bv1JeInclg m2bITo8Yo2G0lse2ZFcLr7uoQa4eElBXx6OnRatGaX58NVRLIEYR55Obin5zl7Fepdhb 2v5g== X-Forwarded-Encrypted: i=1; AJvYcCWZ55M6RmyUzQ9ACrP299TAAt67hTuQLAcrBzFpAXqjORYGgboED7sRtX68JFpG/QO5ZZRMicLiiHkXNg==@sourceware.org X-Gm-Message-State: AOJu0YwPTumNQuiqI0FD7FAJyG0SB75giWiwgvlwz5Mr5ABuGYAFn6Lk NU3MtMQgj/K39BGwUtAK8cFiCqbAecp1s1/IYwKJ8FQBV5jQa+WXdE+bFBDrKt6IPpzMisS0O/j q4JJ5tKfJt0ZSLJXkBm58FMpgDnvuzU5XfC434NVupUh6lCnV5VLbopjn89MT5i8UDekSvis= X-Gm-Gg: ASbGnctholKM4f5dJeBbM3u/lznAxDBacnNoDC/WkjCa9m3gpCqDrnH+wkzcdzZ6j+u poXx1ceYHXcQIimpTBXpY1ZFfXQYPx3DFxa1Ygo+VydX8803ElxZZJG5/i60Z2HiW52i076MMsa V8GI/424W34m5h6B9tKylnSwvm+S20JC/pvt9EKQyLttuvBnHJwB8/hGI4YGg8TGDDC0VNtMfjT TdG+98UuJrEsHvDnGkGygW05jV/4vO5iUd6J/cgaFwSxQ2ll0jY9rHOHRu3Blx9iGF2Nw9qo21o gRXKfOBQO8HWJMcOhxwdHsUbiC1l6/2dvvD/gr6Onn6CmyCHhPSzfmA9QJ882LEMEheyZwxVv7M EONKf X-Received: by 2002:a05:600c:474b:b0:477:a21c:2066 with SMTP id 5b1f17b1804b1-477a21c2122mr110493185e9.5.1763563499484; Wed, 19 Nov 2025 06:44:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGft9EEhr4WqZ02C0ZF8//3VZQqSSAEVvmVBPYiJNr5gSQaeGpYosxpi4S3M8b73VTCy8mKFA== X-Received: by 2002:a05:600c:474b:b0:477:a21c:2066 with SMTP id 5b1f17b1804b1-477a21c2122mr110492955e9.5.1763563499109; Wed, 19 Nov 2025 06:44:59 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a97213b8sm42534085e9.1.2025.11.19.06.44.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 06:44:58 -0800 (PST) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 6/6] gdb/dwarf: use dwarf2_per_cu::ref_addr_size in one spot In-Reply-To: <20251107211041.520697-7-simon.marchi@efficios.com> References: <20251107211041.520697-1-simon.marchi@efficios.com> <20251107211041.520697-7-simon.marchi@efficios.com> Date: Wed, 19 Nov 2025 14:44:58 +0000 Message-ID: <87ecput72t.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NcvR-BNixAZ70APx1JAi8hyCMp_pDJbL-UkB3Z3PBK0_1763563500 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > From: Simon Marchi > > I noticed this spot that could use dwarf2_per_cu::ref_addr_size, instead > of implementing the same logic. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: I894ef1dcaa687c659e49bc1eb433e42818038cf2 > --- > gdb/dwarf2/read.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index a8b9798c4e8e..c355cc2bb5cb 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -3866,12 +3866,7 @@ cutu_reader::skip_one_attribute (dwarf_form form, const gdb_byte *info_ptr) > switch (form) > { > case DW_FORM_ref_addr: > - /* In DWARF 2, DW_FORM_ref_addr is address sized; in DWARF 3 > - and later it is offset sized. */ > - if (m_cu->header.version == 2) > - return info_ptr + m_cu->header.addr_size; > - else > - return info_ptr + m_cu->header.offset_size; > + return info_ptr + m_cu->per_cu->ref_addr_size (); > > case DW_FORM_GNU_ref_alt: > return info_ptr + m_cu->header.offset_size; > -- > 2.51.2