From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7cZ/NZzsHWkaEBQAWB0awg (envelope-from ) for ; Wed, 19 Nov 2025 11:13:16 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=nhCgMnLC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CCF6D1E048; Wed, 19 Nov 2025 11:13:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4F53C1E048 for ; Wed, 19 Nov 2025 11:13:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D684B385C6DA for ; Wed, 19 Nov 2025 16:13:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D684B385C6DA Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=nhCgMnLC Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id C28893851167 for ; Wed, 19 Nov 2025 16:11:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C28893851167 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C28893851167 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763568688; cv=none; b=W1VDNRK4FwnM4zo937TdYg0zBO3BqnYvTxbm1ZtWYKFCwVmW3XMnnABRhOEwkut44CwblfB12E8+1FyjReZl9Dc2Bu2DJgvGezSY0z+Yc8tRat8l+bRZkol9KJA5s4ogcsT6y+60sDUURdu6eJB1SR7t426p6kdPrsL0rflG73w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763568688; c=relaxed/simple; bh=MyQ3vxl96SmEnKezUHL+Mm1B9rXa2dWHx1xDQ6c5NgQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PSXzd50t+gkjQ5L7Vr0EoqYyW2HHSZYKtOnLI5QXU2zC+MnIO9Zs0cEjBPJPgOCWK0kT4k32TnxhwoHppHtF9mLdm82VzzgrxuPrRos1xhr7gKZgx9LDn+2IVJFxrEE3Otp0mptR9N7BazDpsvoDmamSZxxiF+aLp8MHNwa6hGE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C28893851167 Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id LkjMvCjV9SkcfLkmGvm69o; Wed, 19 Nov 2025 16:11:28 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id LkmFvy0e5APklLkmGvqnSA; Wed, 19 Nov 2025 16:11:28 +0000 X-Authority-Analysis: v=2.4 cv=W404VQWk c=1 sm=1 tr=0 ts=691dec30 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6UeiqGixMTsA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=3o3Q_U6OOB2ZB83fyoYA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1io+vi8uiRm06NOt/OM2YM/ieOAfTxmYQEr3yr3u2as=; b=nhCgMnLCA+qatL7tGn5Ioa0LIi cG2BLvM4gtcXNMzEjIzIYP35pHflEVwFmak6iSswOFuPNlGM5xRf+hyjWgt/aQc3TEOOmbP0eEhiS o3IcAd7OfTFFUONL8WZ/JtPxR; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:38816 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vLkmF-00000000yDj-0JEv; Wed, 19 Nov 2025 09:11:27 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] gdb/dwarf: when in dwarf2_cu, read addr_size from dwarf2_cu::header In-Reply-To: <20251107211041.520697-5-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 7 Nov 2025 16:10:15 -0500") References: <20251107211041.520697-1-simon.marchi@efficios.com> <20251107211041.520697-5-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 19 Nov 2025 09:11:26 -0700 Message-ID: <87ecpuq9xt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vLkmF-00000000yDj-0JEv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:38816 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfD1d/4Vhaq+j9K3xCOmZt2YRgxBesHvRMZ0Cm23C9zwFq8TJL+e64UyDgclhvv7pAMBqpg+nHxttlSofVwtsmCJRenkCrxEAXPQaNSmG6MFHRx7bjF6e bvX4oA2g8VnhSDm8hV6kDBiA038ADQ17Z3aJbjfAiFxqoVKZ/e+xJK2FFR1HclQXUWwJZBPs9nyT1PJBouSLXvNxKUVKxIo+ba0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> I would prefer to not reintroduce the behavior of overwriting the Simon> section info in dwarf2_per_cu, because: Simon> 1. I find it confusing, I like the invariant of dwarf2_per_cu::section Simon> points to the stub, and dwarf2_cu::section points to where we Simon> actually read the debug info from. The "overwrite" behavior was super messy and hard to untangle, so +1 to getting rid of that. I was wondering if the new invariant is sufficiently documented. I somewhat think the comments in dwarf2_per_cu should be updated to explain it. Also while dwarf2_cu::section has a comment, I'm left wondering about dwarf2_cu::header. Tom