From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /QbCB3GkOWkyTiwAWB0awg (envelope-from ) for ; Wed, 10 Dec 2025 11:48:49 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=vWWQ9vb2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0D3521E0B3; Wed, 10 Dec 2025 11:48:49 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8F8FD1E08D for ; Wed, 10 Dec 2025 11:48:47 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 127874BA2E01 for ; Wed, 10 Dec 2025 16:48:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 127874BA2E01 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=vWWQ9vb2 Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 76F694BA2E00 for ; Wed, 10 Dec 2025 16:48:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 76F694BA2E00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 76F694BA2E00 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765385300; cv=none; b=dCKhXg+dWtpn9DsNN7ABIUBXtTO4ZsbSFEblcHk+UjbLGkl9UTIuialZ+zAyjO7gc+Z6xEuVNUGh7Fi47qzpOkWnWszCZtyD8iG8DG4SVcTGL1+ipC39U1f+JlQo2QduAdBmceda2IwKv+gjp0+y0+WCA73YWFNXXVZ1qE3F6Io= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765385300; c=relaxed/simple; bh=ul1yB9HOUPlVFuFjI7uoBDdjXZ0svLtBvTPKOJmtreM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fN5/VVxjIdeNJzk5Ze5t28BBWKdGXtcVrgG590PAy8FV1TKAW1KPF4tR3iNovQdnf7Kg0n/G2fvJpB5h9uxsgrEdVqzEWoixf/bZRZAVkhz0fPN+YIikV/u3rPe+fxsb4hhpQXln1nRd1TowfdkCgwDMPTQcna0vNBF1GVZVZZY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76F694BA2E00 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id TD6JvOVkbaPqLTNMRv6oYT; Wed, 10 Dec 2025 08:48:19 -0800 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id TNMQvQ2A32l0kTNMQvm8Sw; Wed, 10 Dec 2025 16:48:19 +0000 X-Authority-Analysis: v=2.4 cv=UfRRSLSN c=1 sm=1 tr=0 ts=6939a453 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=Sa4HaZcoRwP5fRMrJ7IA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HXdKprnIj89Nn+4FvOimyeG5ID1Kudf34MZSHi7bG6s=; b=vWWQ9vb20009MijayH6mLKWWm6 7ooIpQpPPY2LzDvAf6lOLdFlmLoFOI+e8tSvYrNVtB98AHDKDS5BX0JoWNgHAI5KY8c5vv2E+KZhU ArOocGGeE+M4YYqk+bI0tVBxJ; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:57804 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vTNMN-00000003f1i-1Ngq; Wed, 10 Dec 2025 09:48:15 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Guinevere Larsen Subject: Re: [PATCHv3 1/3] gdb: make get_chars_per_line return an unsigned value In-Reply-To: (Andrew Burgess's message of "Fri, 5 Dec 2025 19:53:15 +0000") References: X-Attribution: Tom Date: Wed, 10 Dec 2025 09:48:07 -0700 Message-ID: <87ecp22shk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vTNMN-00000003f1i-1Ngq X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:57804 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfF0Mebc8B0/b+VdlAYof8vnW3efbju8ONiLG2eWzS2HTeEPuVUXcXH8oylvpKNhm/GKZ2ORGFUVP4aeyHIbeCHjIol7jX61+6wMf+6utAQv54SHwN8ci BivkGf1nzErxgISxpy2SWBWTAO3y9corV6mAALmBr2YOxteWRPfDdwrxAuNJUmI/Syw5vbO8Dts+qOvZC0/PbsRMQFeMIWECckA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> This commit works around the signed / unsigned confusion entirely Andrew> within print_gdb_hints by adding a case to 'int' in one place. The Andrew> change I present here reverts parts of 06e470d8fc0a in favour of Andrew> fixing the type of WIDTH within print_gdb_hints. Andrew> It is worth nothing that there are other bugs in print_gdb_hints Andrew> relating to how WIDTH is handled, but these are fixed in the next Andrew> commit. [...] I think this patch is ok. Approved-By: Tom Tromey Tom