From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8f8MHDwer2lXnyAAWB0awg (envelope-from ) for ; Mon, 09 Mar 2026 15:23:40 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=EGFVS+F7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6D6231E089; Mon, 09 Mar 2026 15:23:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CEA821E089 for ; Mon, 09 Mar 2026 15:23:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 689324BA23D5 for ; Mon, 9 Mar 2026 19:23:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 689324BA23D5 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=EGFVS+F7 Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 8613A4BA2E13 for ; Mon, 9 Mar 2026 19:23:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8613A4BA2E13 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8613A4BA2E13 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773084182; cv=none; b=dW74AIRnAgIHhbVitjkLlNlIdUZhEs9WrtDM0G3lmRqIrFDqzw7OE7mORQL9ym9KG9PjjivPWSUe2dzHoK7I2Xwjqbp0cA+8Q2Vum7otv9NrzvbEYEakKGukU6u5bMHFwFxNsWsvGXtCPduXVTVfkOyCB0wFIfNlzVEqWXmss+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773084182; c=relaxed/simple; bh=kHD96xVULYGNlMou0ulrLUqY6u33+3NZXxuitdOtO60=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PsKHOa/RgV+eN4nZrSvE+M8CJeGdLOmUQqGL5v1lXzpcD7qrCsOAlyJSXu5dzk8PhMKp6CKWzHaxaBl6ogmBdsArjHMvylMjnF2bPr6huFr0TJjHRZ1kJKKzYYZK8WEs7sTcF5NgLW++plSx5dcTFnuuLVQhzyHkWzJNCRikrhk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8613A4BA2E13 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id zd1cvxA1UVCBNzgBxvaUuq; Mon, 09 Mar 2026 19:23:01 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zgBhvKZGO2l0kzgBiv94OA; Mon, 09 Mar 2026 19:22:46 +0000 X-Authority-Analysis: v=2.4 cv=UfRRSLSN c=1 sm=1 tr=0 ts=69af1e14 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=zstS-IiYAAAA:8 a=UGnbxyDBsfa-LybGJmsA:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=c/Pc3+NMDKYRxwsgYarTmeo0jTSi1QKlaPV90zqLY/k=; b=EGFVS+F7KeqOcigZmMASnrHlYE 2tDqITNFlKTATvp/X9l/qtcrURPBnpm+rDYrmiDzohtpL6i3B1RPujTwgM2XMRV/xkTvd8i0wwEDd kGl2L5+MaCq0If4tyZCOVs5je; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:55972 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vzgBh-00000003Ija-2GsU; Mon, 09 Mar 2026 13:22:45 -0600 From: Tom Tromey To: Matthieu Longo Cc: , Tom Tromey Subject: Re: [PATCH v3 1/7] gdb: introduce rgb_color type to simplify existing code In-Reply-To: <20260309175624.236491-2-matthieu.longo@arm.com> (Matthieu Longo's message of "Mon, 9 Mar 2026 17:56:18 +0000") References: <20260309175624.236491-1-matthieu.longo@arm.com> <20260309175624.236491-2-matthieu.longo@arm.com> X-Attribution: Tom Date: Mon, 09 Mar 2026 13:22:44 -0600 Message-ID: <87eclsx0xn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1vzgBh-00000003Ija-2GsU X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:55972 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCWtO/tCo3Dkv7+wb5JncbgXnV6VJKRkKm6OHJ422zCLEp4501kTBj58G3W5P+6zaC+tXcMrcbBZ6j1AP9OJR9GyaJc0EmaUcOeP82Z4TJVOx6+7lnWq 8mxGgJf93Q1hEinIZACR+UCq0f+O+2GoP3LgWm1JyQeS00VFXY19Gc/+UApclddWpU6fdn3YN93/wOZG4CrajJjBuZJSXWC6PUc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Matthieu Longo writes: > This patch replaces the raw uint8[3] buffer used to represent RGB values > with a more convenient wrapper, rgb_color, around std::array. > It also changes the return type of ui_file_style::color::get_rgb to > rgb_color instead of filling a caller-provided buffer, and updates all > callers accordingly. One tiny nit. > if (target_space == color_space::RGB_24BIT) > { > - uint8_t rgb[3]; > - get_rgb (rgb); > - return color (rgb[0], rgb[1], rgb[2]); > + return color (get_rgb ()); > } Since there's only one statement now, the braces should be removed. This is ok with this change. Approved-By: Tom Tromey Tom