From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oV70JXIA8Wm8dAEAWB0awg (envelope-from ) for ; Tue, 28 Apr 2026 14:46:10 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=bK5FWXnu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 976931E0BA; Tue, 28 Apr 2026 14:46:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EDFE81E067 for ; Tue, 28 Apr 2026 14:46:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8E3A14BBC0AF for ; Tue, 28 Apr 2026 18:46:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E3A14BBC0AF Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=bK5FWXnu Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 441124BB8F6C for ; Tue, 28 Apr 2026 18:45:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 441124BB8F6C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 441124BB8F6C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777401945; cv=none; b=pT6/5XLjIWv+sjfUTr6kaNBtiJRi4Zq0JI1hmoA0c//Ofp6O36knQg8ets8QUvZUtl5LQkv/twsaFLiZSt0+TzowdqM1Hp1+6AZCNl2Iv/edf/YXJfhW5yCLBYhzotTmL/rARdUGlm9SXnbEuSOTz/nlGZiBNAsS/sDu9TrJAEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777401945; c=relaxed/simple; bh=llX4HoWM3MSKzpE7+2Pxqux7BHXtRtHjh3iptCsGEVY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FEs03PrE9g6K/r3tWg1JX4wK1jyk2r7okJj94/VKQe4u5qlBY3pUEyKnkjWTMmAYhAuW/ZyQnGMYbYm5qOdjI8twNjA/UZXGr+DYWnBcvhUgwZ2XhHveHJYZCe46f7guPiYsU3FMOnces1IQQA4137fdGHAOnCm+Ex9pZdmTM9E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 441124BB8F6C Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id HmkCwvkpmnwj2HnRIwOL3q; Tue, 28 Apr 2026 18:45:44 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id HnRHw2poOw84vHnRHw5nWp; Tue, 28 Apr 2026 18:45:43 +0000 X-Authority-Analysis: v=2.4 cv=ZIbXmW7b c=1 sm=1 tr=0 ts=69f10058 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=rPaYND2robRXyAGz-9EA:9 a=M91JV_wKSCcA:10 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3Xy3cgLoEt7ICAIOyJrYRtaZ44w/qHrKQe4c4BLL8VY=; b=bK5FWXnuSgk+9JKuQkEQN5g0d0 x+k/XBoa5JkZAci24mRObB3bdAR8PD31EWT7+nBVeP1YImYap2Wssmo5X/U38vnkTUFOFtjaSlQGT fHBg02uHoGukVw0fquYe8NeF1; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:41758 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wHnRH-00000001vj9-1PFh; Tue, 28 Apr 2026 12:45:43 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 5/8] gdb/dwarf: generate foreign type units in .debug_names In-Reply-To: <20260416200256.386186-6-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 16 Apr 2026 15:59:08 -0400") References: <20260316232042.368080-1-simon.marchi@polymtl.ca> <20260416200256.386186-1-simon.marchi@efficios.com> <20260416200256.386186-6-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 28 Apr 2026 12:45:42 -0600 Message-ID: <87ecjykjop.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wHnRH-00000001vj9-1PFh X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:41758 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOBHU4fLxNpgQiez2ZAzwObPfzj7Z6CyOmvWVdRKA2DeqmBpHMuyh9yNcPSpttpcqf9Lu+VryX+gK0ejiRsM/MBXO5JUqxlSxxwfk2jWKgbDaXI5abMw I/pNbsSDBs9F2NraDSSyX+QH6bX0alMRwRGPIpBHyJyNDLEkWSqOWXcVv2IyrQcGjiFIA2avF/CDJKx+Tay5gipIkq7UgzllDqk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> + if (per_cu == nullptr) Simon> + error (_("Could not find a CU for foreign type unit in " Simon> + "DWO file %s"), Simon> + sig_type->dwo_unit->dwo_file->dwo_name.c_str ()); It's possible to style error messages now. Though I don't know if we really care about this one. FTR I did not bother to convert a few similar things in the DWARF reader. Approved-By: Tom Tromey Tom