From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rxJsHkEOYWqZfiYAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 14:38:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AVrNceAD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 69AF81E09E; Wed, 22 Jul 2026 14:38:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9E6971E033 for ; Wed, 22 Jul 2026 14:38:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E65D94BA2E35 for ; Wed, 22 Jul 2026 18:38:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E65D94BA2E35 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AVrNceAD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 3204E4BA2E0C for ; Wed, 22 Jul 2026 18:38:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3204E4BA2E0C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3204E4BA2E0C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784745505; cv=none; b=dzRz4mb+4UadpvyiJTykKWewQ1sO00gYw5RPK07CE/IxrHGxt75dZc6HK3yDQtmqLfhMdUXCtb90fgc+51GEmnELgNffCVc/bxcoDy0Zin70/MSB9p5VKUFoS0RDcKO7bVsvvRoQLmhJFT1NQtoe2laW6bxzSlEk9NURl9qkzpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784745505; c=relaxed/simple; bh=m7QUVvF5VJRgHeltZ7vIpHMQKZBQgeQZQXwz5aZj7jc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=J4cgxryIF7FQ6mz7Tov52ZS6k9W4QccCnq/E3BuYsP8hSfiD1XiiPRPWchUz1PhJCzJE+0NBSXGKYpCNOr7DkzeW0n0LVYf4QAFjBRXU/TLYN/BPfF9OsF1RAuc8RQu/3i5LNAMBgC9td48tx10769x77XkyW7w+D2W/CUnfzQs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AVrNceAD DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3204E4BA2E0C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784745504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MF6R7YSw/eHpW+3Qeaw9HQZwWtB4YGivvd9m+/sg+o4=; b=AVrNceAD0eIH/4AEAAkr1WSQvqOce9Concau1IkZUttqAWvglVzQnjJ6wvEfEYAU2dQioq a12flS4fnggiyQtypEn+9JBeGD80bnOFgXTSvFPKtGyAgeHfXIn95ZKV75AmoS8fki/lJS vb9SdZFIh5kpm5g3nsgWLRHwHBI+0Gk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-blpRb3H6MvytRgwrGiE2Cg-1; Wed, 22 Jul 2026 14:38:23 -0400 X-MC-Unique: blpRb3H6MvytRgwrGiE2Cg-1 X-Mimecast-MFC-AGG-ID: blpRb3H6MvytRgwrGiE2Cg_1784745502 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-473ac08a6a4so8604784f8f.0 for ; Wed, 22 Jul 2026 11:38:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784745502; x=1785350302; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MF6R7YSw/eHpW+3Qeaw9HQZwWtB4YGivvd9m+/sg+o4=; b=nTXqAkPNXPSlYodmoydaISZ+o+RUy8CnH+38frpyBIwo6BV+zw2iFrjAoa3mEITKEV emCjy98SClR8tBpWP1f2oeQqhupglJAQ+JFOgrxdu2RUNBFmngRsXJAkyus9soXrt8iI 6tA/Qdr1sZJODM0x5eYukHdcLvdvPDwNjJB2FfCAhQM2ar0BaF4Z68HDDQhIDVIvTQjc qQMsvhehKMhzpHcCKAhb4K86HRq4QeJnUBQhJQjpWAcmKXJpd1lbqXyUf00E8uHWgluL MgctgmuRF7IyhwvPL5PzQVt/9/co0EaYSCadpLKwIoQRO2sY4gtKtq9qczb/IfqwXhRI bGIQ== X-Forwarded-Encrypted: i=1; AHgh+RpYvp2k9P3MWlZTVv5kc3akN3GHmGbJ+zQIAWfUG2PUILp8VEpM2A1QDNdQYa2bb1+8QL8dMGIvjmO2Dw==@sourceware.org X-Gm-Message-State: AOJu0YwoN8ai+RD4MMCORvuKA4CX6i+CAxfPhBLPGjEWlXkUCcTNymxF +FEzatZRo8YhRjdJJSlI6BEY9cr6TVYDlcWaCTZnRAE6v3gxriPDiu/8/yJzOF5PJnB6XTL3ivx qbTXT61TRugDBx6EocF8hogPyIKPJvq9746E+33e9fNxfVaILUhu9zJx3UNdnrOnStHc7Yw8= X-Gm-Gg: AR+sD122CvFSnxZbbegspO5gNmXjZCXVY3w4yNNsKfraclIWK7eHAw81zK8kZrhnn5h 8h+iOu1RPkbTnlk/1vaaSv2y06sOCgW3PSS8B9lywrw8yjAmhakr+c1i/kHYGFAksPctMXXTYL5 k/hE5wQxOioOamtJFQbW6uGuAlaGI5+JmqhbtjJMzcheHcocIXCmYHhopUhEfIZGh4JJwGmSGL3 4DTzpPEVK5arYrrrU/EceeajLInvOGamr/GQZvAvGmz+/8Ngr+mU+ovqgbo684jT2goZb49Mwtr iILLmGV7EdIBXmQ5ceT90gZwCpsgT2OZ6xVke4LSbKpGvimy5FYaJXGNFSlMjjMzFtvxKkIC2O6 DW9go5ZjUqzwj8Gw5sXvefWvL X-Received: by 2002:a05:6000:22c9:b0:47f:83a1:6b7 with SMTP id ffacd0b85a97d-47f8da7885emr34513f8f.21.1784745501970; Wed, 22 Jul 2026 11:38:21 -0700 (PDT) X-Received: by 2002:a05:6000:22c9:b0:47f:83a1:6b7 with SMTP id ffacd0b85a97d-47f8da7885emr34474f8f.21.1784745501535; Wed, 22 Jul 2026 11:38:21 -0700 (PDT) Received: from localhost (92.40.185.178.threembb.co.uk. [92.40.185.178]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85c635e5sm8220974f8f.26.2026.07.22.11.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 11:38:20 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH] Export SHELL before invoking lineno.sh In-Reply-To: <20260722142036.3276670-1-tromey@adacore.com> References: <20260722142036.3276670-1-tromey@adacore.com> Date: Wed, 22 Jul 2026 19:38:18 +0100 Message-ID: <87ecguq38l.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DAr-MonopcArwpzlcU1_DqSqgPzT3XB0dRy4Oo3YFSo_1784745502 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: > A user reported that building the sim failed, because their shell was > not sh-compatible. In particular, lineno.sh uses $SHELL to invoke > another script. > > This patch arranges for SHELL to be exported when invoking lineno.sh, > ensuring that the correct shell is used. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34407 > --- > sim/Makefile.in | 2 +- > sim/common/local.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sim/Makefile.in b/sim/Makefile.in > index 5438d778a3f..1f9bbfec03f 100644 > --- a/sim/Makefile.in > +++ b/sim/Makefile.in > @@ -1994,7 +1994,7 @@ CGEN_GEN_CPU_DESC = \ > $(CGEN_ARCHFILE) ignored $$opcfile > > CGEN_GEN_MLOOP = \ > - $(SHELL) $(srccom)/lineno.sh \ > + SHELL=$(SHELL) $(SHELL) $(srccom)/lineno.sh \ > $(srccom)/genmloop.sh \ > $@.lineno.sh \ > -shell $(SHELL) -awk $(AWK) -lineno $(srccom)/lineno.sh \ > diff --git a/sim/common/local.mk b/sim/common/local.mk > index 01712aee98d..f765cf57fea 100644 > --- a/sim/common/local.mk > +++ b/sim/common/local.mk > @@ -234,7 +234,7 @@ CGEN_GEN_CPU_DESC = \ > $(CGEN_ARCHFILE) ignored $$opcfile > > CGEN_GEN_MLOOP = \ > - $(SHELL) $(srccom)/lineno.sh \ > + SHELL=$(SHELL) $(SHELL) $(srccom)/lineno.sh \ > $(srccom)/genmloop.sh \ > $@.lineno.sh \ > -shell $(SHELL) -awk $(AWK) -lineno $(srccom)/lineno.sh \ > > base-commit: 293f50b84a9664213fde309e2dc51a49d719029c > -- > 2.55.0