From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kegdA4k6Y2rcOysAWB0awg (envelope-from ) for ; Fri, 24 Jul 2026 06:12:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FVrNApog; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E1B5E1E09E; Fri, 24 Jul 2026 06:12:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 035B91E099 for ; Fri, 24 Jul 2026 06:12:23 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E43B74BA23D9 for ; Fri, 24 Jul 2026 10:12:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E43B74BA23D9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FVrNApog Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1E0814BA2E3E for ; Fri, 24 Jul 2026 10:11:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E0814BA2E3E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E0814BA2E3E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784887912; cv=none; b=GmbkEyKH9wYw7QDjUnAeLaBzyzJNC92C1gTqtIG3BRMWm/J5IPhT1514RC6IkUL/VegMIl8k46cpiuhq1cQvNSqWjK91Ozv5ggQXfMOgxASueVU/hT2DXzgKnqpd1TneYUw02jspEvjsILx/zh3sRj4d485ADScJOa+7IENxQGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784887912; c=relaxed/simple; bh=QQ9L/jyYQDayx54G88VbE4cSS/Uf4YxtsXgDPgRmDJ8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vTepV1XB4efrhjPqCyp6giy9wF6zxCiAmCPUr1kuK+Q4PnlGvtkW3WwCx8q/7oCCyGQFus/0jQDYEKbMdT3E95DqFs6xHkZF3CHuA4CHYHiB84WHIZEnXCz2EgnN6qCYIsQjuKgyiNlO8xIo4K+AOIRAhemZj6nQw+/EY7YzrBc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FVrNApog DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E0814BA2E3E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784887911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NJshzXD+cgZHpEtnn7auZKUv6WR3kXK1C1/Oz/Njgt8=; b=FVrNApog5+UXedIvu38IkUwvUfM+zePWxTZn3bOv5ufbW/JgQDZgjjklpOglgmUBFBh+QW 7VOdCEfkVw13dO7PaVXr+YhLu31jAUjKPOnXAQXHxMjDm5JrYGBf3KdbCk8y64T+0LnDXQ FU52OnZ/0VUauGCbMVGSXF1THnEQsR8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-362-nkrTURjGOIOx81cZz1G_JQ-1; Fri, 24 Jul 2026 06:11:50 -0400 X-MC-Unique: nkrTURjGOIOx81cZz1G_JQ-1 X-Mimecast-MFC-AGG-ID: nkrTURjGOIOx81cZz1G_JQ_1784887909 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4957287363bso2207785e9.0 for ; Fri, 24 Jul 2026 03:11:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784887909; x=1785492709; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=NJshzXD+cgZHpEtnn7auZKUv6WR3kXK1C1/Oz/Njgt8=; b=S44EPfF9YZyGv3U8aToHBu3FikRA0Vd04cBOvMkaZppRITy7wsuJgbOt0rCtu3h8Us rihBu7oPDHhWl7xj0OHddWHCLfvuhAKsqA6gCby/VAJdhJwlFuTMNZn+xPncf+lKe9Ey Brwm8bBhMblZziDPa3tdK4z4WGPfjltf6T60rxLggAM0efATuUbz65K8+IFnesq3ULmH 62S1nxW6Y+yoiYis4wIRBM1U+G53lshTxep2PFc6p4foytjXaF1qiipa95IDGW3csLDB rRF7kLui6f3zLhEtJn756vjqpBAguvmDli+LbB3CFQZlfb3cwApG5TUdoPkWc//eaaSm t6FA== X-Forwarded-Encrypted: i=1; AHgh+RqPCvtQBjgxjaPHtwmwKIzcLfY+GF440kibln09/dmMe+vHNEjSd6BczZ+SLiTrOfIdnzuc4UpqeqlZ0A==@sourceware.org X-Gm-Message-State: AOJu0YzOfRw7TJE3Uu4DZJ8ybgoi9rAiKedfkB6QjYZYqoJkDTIIHJYe G+zpTdgntBHyszOLKhMfCRZMKlMcegJ4pPlSxNxSPYY9K6o/9znaOE5PyNmL/sNKLMkyJHAdHGI DPWHwIYrPL9coCyHmWh66EsuaqN8Hd1uY1sQUHUCieDA8NUxd7v4JYvF/QmJe1yc= X-Gm-Gg: AR+sD11L0+qFx8Vjk0WW66x50L6qSLuT7BGgfGPRJAZaV8ay1arir1ohz4b9uar0NED hMgbUd2ifGKIW9W3IwC11UQ3M01D3yyNMaD/tikpmVgakvWkmwGVeLIDqDzHYD3POHgqbgHNLzZ MlBz5iLZVjyUjXTxuCK9h/w7ElcA5kyssNp2lgbEkJVSbOPaNaS2HS5x808IHGAIISKTtLsD8Jy JWMXaMJ4b3bisZ5bSh6DSF7nxXqmut0SWsadPxMPEP3J190KYuliS+YAgewT21EZgY77e4xIowb H71YrEYRATG6o7w9SiDxclVr4Jv0iFP5msDEcuA/1rwsWu3F6pBE07BXMZ05XNcXHMtVbeIl X-Received: by 2002:a05:600c:5706:b0:495:7287:293f with SMTP id 5b1f17b1804b1-49573d26dd5mr56942825e9.35.1784887908654; Fri, 24 Jul 2026 03:11:48 -0700 (PDT) X-Received: by 2002:a05:600c:5706:b0:495:7287:293f with SMTP id 5b1f17b1804b1-49573d26dd5mr56942555e9.35.1784887908209; Fri, 24 Jul 2026 03:11:48 -0700 (PDT) Received: from localhost ([31.111.209.233]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957bff4784sm40202115e9.4.2026.07.24.03.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 03:11:47 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH] Simplify ada_parse_renaming In-Reply-To: <20260723154306.3708516-1-tromey@adacore.com> References: <20260723154306.3708516-1-tromey@adacore.com> Date: Fri, 24 Jul 2026 11:11:46 +0100 Message-ID: <87ecgsofx9.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kxxSsJbXtvVhDeARq4h81nWtBq_E6AH-Dofyef09xtA_1784887909 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: > While working on gnat-llvm, I found that ada_parse_renaming checks the > "loc_class" of the symbol. This caused a problem with my WIP > gnat-llvm patch, which emitted a renaming symbol as LOC_CONST. > > I've since fixed my gnat-llvm patch; but nevertheless it seems to me > that there's no need to check this. In Ada, no user-provided symbol > will have an "___XR" substring, as such symbols are all lower-cased. > > This patch removes the check, simplifying ada_parse_renaming. I cannot claim to know if your claims about Ada itself are correct or not, but if you're wrong you'll be the one fixing it! The change itself is as described, and clear, so: Approved-By: Andrew Burgess Thanks, Andrew > --- > gdb/ada-lang.c | 50 ++++++++++++++++++++------------------------------ > 1 file changed, 20 insertions(+), 30 deletions(-) > > diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > index a7019a4522c..d948c68a012 100644 > --- a/gdb/ada-lang.c > +++ b/gdb/ada-lang.c > @@ -4400,43 +4400,33 @@ ada_parse_renaming (struct symbol *sym, > const char **renaming_expr) > { > enum ada_renaming_category kind; > - const char *info; > const char *suffix; > > if (sym == NULL) > return ADA_NOT_RENAMING; > - switch (sym->loc_class ()) > + const char *info = strstr (sym->linkage_name (), "___XR"); > + if (info == nullptr) > + return ADA_NOT_RENAMING; > + switch (info[5]) > { > + case '_': > + kind = ADA_OBJECT_RENAMING; > + info += 6; > + break; > + case 'E': > + kind = ADA_EXCEPTION_RENAMING; > + info += 7; > + break; > + case 'P': > + kind = ADA_PACKAGE_RENAMING; > + info += 7; > + break; > + case 'S': > + kind = ADA_SUBPROGRAM_RENAMING; > + info += 7; > + break; > default: > return ADA_NOT_RENAMING; > - case LOC_LOCAL: > - case LOC_STATIC: > - case LOC_COMPUTED: > - case LOC_OPTIMIZED_OUT: > - info = strstr (sym->linkage_name (), "___XR"); > - if (info == NULL) > - return ADA_NOT_RENAMING; > - switch (info[5]) > - { > - case '_': > - kind = ADA_OBJECT_RENAMING; > - info += 6; > - break; > - case 'E': > - kind = ADA_EXCEPTION_RENAMING; > - info += 7; > - break; > - case 'P': > - kind = ADA_PACKAGE_RENAMING; > - info += 7; > - break; > - case 'S': > - kind = ADA_SUBPROGRAM_RENAMING; > - info += 7; > - break; > - default: > - return ADA_NOT_RENAMING; > - } > } > > if (renamed_entity != NULL) > > base-commit: 39fc0cc4aa6f82a73b9eac6b8739895484ab269f > -- > 2.55.0