From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BJG2GHbRfGrUKiEAWB0awg (envelope-from ) for ; Wed, 12 Aug 2026 16:03:02 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pueDpGRb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4CA771E09B; Wed, 12 Aug 2026 16:03:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A774C1E09B for ; Wed, 12 Aug 2026 16:03:01 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56A484B97004 for ; Wed, 12 Aug 2026 20:03:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56A484B97004 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pueDpGRb Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id E1A664BB24EB for ; Wed, 12 Aug 2026 20:02:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1A664BB24EB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1A664BB24EB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786564955; cv=none; b=lfnBwu5IO08WTymBND2+0CE4NtNRO+StrHlvd3UB+SsybHKPnw5BAXqWZt61Wj1bAhERBPKAIf73nWxuojkEVRulETfezKnw+xBLzBubcefOBhgu6yiYT/U1zAhPz4PYGwVhVe4XfhfAncat2umdhAjb9QarHKGQfINm4yMEU2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786564955; c=relaxed/simple; bh=RDMuwCRhk5HMjYsH9Fgc1QvypMX8zt6K739x+rIdBIc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wQ+6UtxCk8BrXGTOimJI/j7Cr1F/nSO4+vuAVFVG1RpZ4aYy5sXtsyVTs7sYamOfI8J6BsehL4K44dma2LaMZoAsViXyQQaRKpLHoskBReRDu/bquUZsosSPprYHKwW+VlaK0oj71miy/IA2YodjAII/6QQ3sDEO5LOQEzgihnE= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pueDpGRb reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1A664BB24EB Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id u9UKw8OXRLvgbuF9mwzc9t; Wed, 12 Aug 2026 20:02:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uF9lw94EALQlXuF9mwIISe; Wed, 12 Aug 2026 20:02:34 +0000 X-Authority-Analysis: v=2.4 cv=AeWxH2XG c=1 sm=1 tr=0 ts=6a7cd15a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=5yod8bXlcpAPXYswNCQA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AE8W5wk2a+fH7Ff1txqE9NUHdYiUQH0D8iyFe6xencM=; b=pueDpGRbK1RhToqkiIFtKdIEBd BOTk+Jp/h6gWxs/06yNkJ9wAvX8Q7HaCfAoMtJcyC34px3JL5EUO22jhadO5UP6otw3Qdk70TZE5k N2TOOqqZ+xqIlEzmEZaPE9jrS; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:54854 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wuF9l-00000003UkF-2cg4; Wed, 12 Aug 2026 14:02:33 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/cli] Don't emit emojis in MI In-Reply-To: <20260812114122.671945-1-tdevries@suse.de> (Tom de Vries's message of "Wed, 12 Aug 2026 13:41:22 +0200") References: <20260812114122.671945-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 12 Aug 2026 14:02:32 -0600 Message-ID: <87ecg3w1if.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wuF9l-00000003UkF-2cg4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:54854 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHAf6i6uXPhuh61xJ9mKygsEUj6TyU6pPbFvzjdvk+h0cgUIAwpJvZ+NZc8JdTpeMGXrjZ612SPsdw9ejOBwZCWYtE9vWpGkpkGYrQ61ZmJKmpi5pO6N T9DEbY6rfao3L+lNEnnVbj7QeE8EI8qKLtxX5IkDygz/tjsFji+HLafEEhSZuXj1C4tLaCOsbZC+XGrdaROqd83yhqJXp4l7YyE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> I think we probably should encode unicode characters in MI error strings as Tom> octal escapes, independent of the sevenbit-strings setting. This patch does Tom> not address this part. I think there are some other bugs concerning this FWIW. I tend to think MI should not set sevenbit-strings and should just use the host encoding. That way, clients could simply use UTF-8 and not have to deal with the oddities here. sevenbit-strings also seems pretty questionable to me. Like maybe it made sense in the ancient times before the charset code was written, but nowadays I think it's just a mistake. Tom> As for implementation, I introduced a function emoji_allowed alongside Tom> can_emit_style_escape, which defaults to the value of can_emit_style_escape. Seems reasonable though: Tom> + /* True if emojis are allowed on STREAM. */ Tom> + virtual bool emoji_allowed () Tom> + { Tom> + /* By default, assume that emojis are not allowed on streams that don't Tom> + support ANSI escapes. */ Tom> + return can_emit_style_escape (); Tom> + } ...there's no present need for 'virtual' here, and if we do ever need it, it is easy to add. So I would suggest removing that. Approved-By: Tom Tromey Tom