From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MSvbIyY5g2qqQC0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 12:39:02 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HJBbmYyR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8ED561E033; Mon, 17 Aug 2026 12:39:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 007AE1E033 for ; Mon, 17 Aug 2026 12:39:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F20F84B9DB65 for ; Mon, 17 Aug 2026 16:39:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F20F84B9DB65 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HJBbmYyR Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id F01CE4BA903F for ; Mon, 17 Aug 2026 16:38:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F01CE4BA903F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F01CE4BA903F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786984692; cv=none; b=jbxF2IAsnQoWRwVjiRiY4JZtcPK1LfOjhZxgR6z734pU9Wua8CZvOU+CaIZBy+htx5V1hWSgIJdb89SlOFQvbWjVt6+xSu/B/DkQx4zkihunKCAgF4QgyExSDNTbE9D6myQbnloBVrmRkCuG9VqfLlie7Z9Hu24ITfa5zhCfa5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786984692; c=relaxed/simple; bh=hEprT8GSyHU8+x6YSDENUmUa88qZR+iwxojpx5Xvtyo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hiXLC0Ufo/JttXMaEwDkhlu0i7kC3SJPhzdAhzbCL9DgP6ptQ7xzooyUBrbbneJRJKwhpvDgRCs1+TCveDiCYsiFqBKIkHXd2sfg9kmn2K6IgXFeZmi+ZA5JU0GN7E+L6D4eOLUfuQ0suCkifTLPv04bh6zT8PHSLQzejT/56UU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HJBbmYyR DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F01CE4BA903F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786984691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ex4lk5hNLIzUW+SehL78KNuz+w/u3e5DD+dlU80djnY=; b=HJBbmYyRtcgkzS0qUPAJjSQpS+b/cH71hwGN8JF/43VsLKnJDNie+VAEFsrjuZ6dOR5nhz LCZX3KE/QqyKtaCaaIOZK2m/4K2hwpMQnFE+JIrt1XxJXisxKyYpvdnpMNPECh0tgqDzEM xnWxT6ed5eyTM8za1k2ICgf7vKUi6Zc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-LGM1h_tTO6ST3YTAlH7KJg-1; Mon, 17 Aug 2026 12:38:10 -0400 X-MC-Unique: LGM1h_tTO6ST3YTAlH7KJg-1 X-Mimecast-MFC-AGG-ID: LGM1h_tTO6ST3YTAlH7KJg_1786984689 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-47f83450a8eso2888556f8f.0 for ; Mon, 17 Aug 2026 09:38:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786984689; x=1787589489; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Ex4lk5hNLIzUW+SehL78KNuz+w/u3e5DD+dlU80djnY=; b=lUBqv9Qo2YCsvwDvT/N0sw9lJsjBIMZDCRt9BMZ8XEFnT/Z/MSPRbcqAA0nk6+4gZH +3FEgHuwh0hb6WRa0Jjm1x5iBK8DJpZfQhKb2xXThhcSP7gjkkz1BzmhYTo9naI18Xcd t4bj31CD+qHLItMnOc33F0EU/qWFRQUMGMyK6eJGSPHHE7JmRvzkiuE10jFPjCh7aTCX eVDvFEMfFwqxAyECZZy5FFkHxy9piC0h3BbWgwh3rCM9CNwPFuUoNGqniJZXMt+exocF OdWKTU7/6Si8s+Jf2lNjhmHoWNnuQRByXqqPI+OHfuBITINqQNl6S1oijHJuvDi4arBW Tbig== X-Forwarded-Encrypted: i=1; AHgh+RpihpKAeTb9V7PzT3m4OnxiO8ze8r9kCrybot327fwPKfrNk1KRsg3W2bJ4yajuylG5WqzRUMfMxOMATQ==@sourceware.org X-Gm-Message-State: AOJu0Yz3iiDZhHVk0Il91MBS8k+wofZ863bU/vc/3oxZGTeF0+KQvroj wcVHXCvKYOe8v7dPNTwl4/HuzNSluRBSgFO1PeS2BoX8XpKIfciCwM2lglX1pfBHHPHUyZYq76w 7zGZ6SgXeYvSGGseCnubKCgLjIjfF14AhwOp7AIPojzNUC14eVx7XUZWIeYPBHb0= X-Gm-Gg: AR+sD12DQHRUN8GoPbpoApkA5Eia3emwjhqGVyGTKyEGqjW4QEeOlq0883VK3X3R2cG U4K36XzE6tmgIE9wKKwH25l3Q1mSgaWiaxYQt8X8dz5JEJJOoquAcj5gybyOyrbc1Ggz7A4Fgdl GgIaoK/1LRnyJVFTXvS18SIrhwq6uHE1IWNHXMeWf0WC8/pVHw7uGWLgHSpxFHx3G/mH9Mfz5af DltkIr2bH6Ove22N/oTGAj9+bs6bHSiVxYrNIcqsl1KjvyYsW+aM0v4FVq1FOaNuafaDzfYNlAk YLL07cG/2YnP0bJS/Cxm53Lj9ok7/sJv8zYomjEsCQYgB+5UcLI7J3V0Uo/sMVS+e3gZgeucpjO b3g/DZLmaNR43TD7TA1g= X-Received: by 2002:a05:6000:4908:b0:474:18d9:8371 with SMTP id ffacd0b85a97d-482a911304bmr2505678f8f.28.1786984688943; Mon, 17 Aug 2026 09:38:08 -0700 (PDT) X-Received: by 2002:a05:6000:4908:b0:474:18d9:8371 with SMTP id ffacd0b85a97d-482a911304bmr2505547f8f.28.1786984688351; Mon, 17 Aug 2026 09:38:08 -0700 (PDT) Received: from localhost (67.72.115.87.dyn.plus.net. [87.115.72.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b816f7sm4974277f8f.34.2026.08.17.09.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 09:38:08 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 09/13] gdb/elfread: remove use of sprintf In-Reply-To: <20260817151646.152571-10-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> <20260817151646.152571-10-simon.marchi@efficios.com> Date: Mon, 17 Aug 2026 17:38:07 +0100 Message-ID: <87ecfw3dow.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2jyYaIFBy7j0IDX_GJ8HbBeq-3kH7CbGrgSMMYzRw-Q_1786984689 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > When building on macOS, I get: > > /Users/smarchi/src/binutils-gdb/gdb/elfread.c:813:3: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] > 813 | sprintf (name_got_plt, "%s" SYMBOL_GOT_PLT_SUFFIX, name); > | ^ > > Change this use of sprintf with an std::string, which also allows > getting rid of a use of alloca. +1 for alloca removal! Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: I296e25c863463ef05eca582c8303557570d63cf0 > --- > gdb/elfread.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/gdb/elfread.c b/gdb/elfread.c > index e3890ae0270c..fcbd0176d08f 100644 > --- a/gdb/elfread.c > +++ b/gdb/elfread.c > @@ -804,20 +804,17 @@ static int > elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p) > { > gnu_ifunc_debug_printf ("resolving \"%s\" by GOT", name); > - char *name_got_plt; > - const size_t got_suffix_len = strlen (SYMBOL_GOT_PLT_SUFFIX); > int found = 0; > const char *func = __func__; > > - name_got_plt = (char *) alloca (strlen (name) + got_suffix_len + 1); > - sprintf (name_got_plt, "%s" SYMBOL_GOT_PLT_SUFFIX, name); > + std::string name_got_plt = std::string (name) + SYMBOL_GOT_PLT_SUFFIX; > > /* FIXME: we only search the initial namespace. > > To search other namespaces, we would need to provide context, e.g. in > form of an objfile in that namespace. */ > current_program_space->iterate_over_objfiles_in_search_order > - ([name, name_got_plt, &addr_p, &found, func] (struct objfile *objfile) > + ([name, &name_got_plt, &addr_p, &found, func] (struct objfile *objfile) > { > bfd *obfd = objfile->obfd.get (); > struct gdbarch *gdbarch = objfile->arch (); > @@ -828,8 +825,8 @@ elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p) > gdb_byte *buf = (gdb_byte *) alloca (ptr_size); > > bound_minimal_symbol msym > - = lookup_minimal_symbol (current_program_space, name_got_plt, > - objfile); > + = lookup_minimal_symbol (current_program_space, > + name_got_plt.c_str (), objfile); > if (msym.minsym == NULL) > return 0; > if (msym.minsym->type () != mst_slot_got_plt) > @@ -850,7 +847,8 @@ elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p) > addr = gdbarch_addr_bits_remove (gdbarch, addr); > > gnu_ifunc_debug_printf_func (func, "GOT entry \"%s\" points to %s", > - name_got_plt, paddress (gdbarch, addr)); > + name_got_plt.c_str (), > + paddress (gdbarch, addr)); > > if (elf_gnu_ifunc_record_cache (name, addr)) > { > -- > 2.55.0