From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH] gdb: track parents of nameless DIEs in cooked indexer
Date: Fri, 21 Aug 2026 11:19:28 -0600 [thread overview]
Message-ID: <87ecfrqtlr.fsf@tromey.com> (raw)
In-Reply-To: <4c16f81081452e05f47741be7a2d15a250827c52.1787152777.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 19 Aug 2026 16:29:22 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> I found this patch while looking at PR gdb/33447, Tom Tromey had
Andrew> suggest this patch might fix that bug, so I took the patch from the
Andrew> mailing list, rebased it to current HEAD, checked the test still
Andrew> passed, and then checked to see if it fixed PR gdb/33447.
Thanks for resurrecting this. I should have reviewed it ages ago.
Andrew> + else if (this_parent_entry != nullptr)
Andrew> + {
Andrew> + /* Record this DIE's parent in the map so that deferred
Andrew> + parent lookups through DW_AT_specification chains can
Andrew> + find the parent even for DIEs that have no name and thus
Andrew> + no cooked_index_entry. */
I just really, truly loathe this part of DWARF.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-08-21 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 15:29 Andrew Burgess
2026-08-21 17:19 ` Tom Tromey [this message]
2026-08-24 18:07 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecfrqtlr.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox