From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32045 invoked by alias); 27 Aug 2002 20:28:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32037 invoked from network); 27 Aug 2002 20:28:39 -0000 Received: from unknown (HELO gash2.peakpeak.com) (207.174.178.17) by sources.redhat.com with SMTP; 27 Aug 2002 20:28:39 -0000 Received: from fleche.redhat.com (tq0209.peakpeak.com [207.174.177.209]) by gash2.peakpeak.com (8.9.3/8.9.3) with ESMTP id OAA00596; Tue, 27 Aug 2002 14:28:35 -0600 Received: by fleche.redhat.com (Postfix, from userid 1000) id 3841F4F829D; Tue, 27 Aug 2002 14:25:01 -0600 (MDT) To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: RFA: osabi.c correctness patch (Was: new build failure) References: <87n0r8i35t.fsf@fleche.redhat.com> <15723.52602.741154.488098@localhost.redhat.com> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom X-Zippy: I'm a fuschia bowling ball somewhere in Brittany Date: Tue, 27 Aug 2002 13:37:00 -0000 In-Reply-To: <15723.52602.741154.488098@localhost.redhat.com> Message-ID: <87d6s4hwwy.fsf_-_@fleche.redhat.com> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-08/txt/msg00906.txt.bz2 >>>>> "Elena" == Elena Zannoni writes: >> ../../src/gdb/breakpoint.c:2732: warning: implicit declaration of function `copy_command_lines' Elena> I am checking in a fix... hold on. FYI, it looks like the problem was caused by an incomplete commit of this patch: 2002-08-26 Joel Brobecker * cli/cli-script.c (copy_command_lines): New function. * defs.h (copy_command_lines): Export. Your fix is fine by me, but the original author(s) may disagree. I'm still working on getting gdb to build with -Werror. I started by turning off the TUI; even with a patch for the readline problem I ran into another warning. I don't actually use the TUI, and I want to use a new gdb today, so disabling it was expedient. After this I got an error building osabi.c. strcmp was implicitly defined. Patch appended. The Makefile fix also includes a minor whitespace bug pointed out by the makefile mode in Emacs. Ok to commit? Incidentally: gdb_string.h relies on some defines brought in by config.h. But not every file includes config.h first. For instance, ada-lang.c incorrectly includes some files before defs.h (I found this by accident). There's another build bug after this one. Tom Index: ChangeLog from Tom Tromey * Makefile.in (osabi.o): Update dependencies. * osabi.c: Include gdb_string.h. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.250 diff -u -r1.250 Makefile.in --- Makefile.in 27 Aug 2002 19:06:34 -0000 1.250 +++ Makefile.in 27 Aug 2002 20:25:40 -0000 @@ -1740,7 +1740,7 @@ $(gdbtypes_h) $(language_h) $(objfiles_h) $(symfile_h) $(symtab_h) \ $(target_h) $(value_h) $(gdb_string_h) $(wrapper_h) $(cp_abi_h) -osabi.o: osabi.c $(defs_h) $(BFD_SRC)/elf-bfd.h +osabi.o: osabi.c $(gdb_string_h) $(defs_h) $(BFD_SRC)/elf-bfd.h go32-nat.o: go32-nat.c $(defs_h) $(inferior_h) $(gdb_wait_h) $(gdbcore_h) \ $(command_h) $(floatformat_h) $(target_h) i387-tdep.h $(regcache_h) @@ -1753,7 +1753,7 @@ gnu-v3-abi.o: gnu-v3-abi.c $(defs_h) $(value_h) $(cp_abi_h) $(demangle_h) \ $(gdb_assert_h) $(gdb_string_h) - + h8300-tdep.o: h8300-tdep.c $(defs_h) $(frame_h) $(symtab_h) $(dis_asm_h) \ $(gdbcmd_h) $(gdbtypes_h) $(gdbcore_h) $(gdb_string_h) $(value_h) \ $(regcache_h) Index: osabi.c =================================================================== RCS file: /cvs/src/src/gdb/osabi.c,v retrieving revision 1.6 diff -u -r1.6 osabi.c --- osabi.c 18 Aug 2002 17:59:57 -0000 1.6 +++ osabi.c 27 Aug 2002 20:25:41 -0000 @@ -19,6 +19,7 @@ Boston, MA 02111-1307, USA. */ #include "defs.h" +#include "gdb_string.h" #include "osabi.h" #include "elf-bfd.h"