Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Weghorn <m.weghorn@posteo.de>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: Patches for PR 25893 "gdbserver incorrectly handles program args containing space"
Date: Thu, 30 Apr 2020 08:03:58 +0200	[thread overview]
Message-ID: <87d6f478-7692-a5ba-1ab4-1707e9dccd0e@posteo.de> (raw)
In-Reply-To: <5ba5d2af-1a96-a17e-baad-bba02f2b7145@simark.ca>

On 29/04/2020 17.27, Simon Marchi wrote:
> On 2020-04-29 7:16 a.m., Michael Weghorn via Gdb-patches wrote:
>> Hi,
>>
>> I have taken a look why gdbserver currently cannot correctly handle
>> program args containing spaces (PR 25893, [1]) and am sending patches
>> that implement a potential solution for this in follow-up emails.
>>
>> This is the first time I'm trying to contribute to gdb and I haven't
>> completed an FSF copyright assignment so far.
>> I'm happy about any feedback on the patches, and also other hints in case
>> I've missed anything when reading the contribution guideline.
>>
>> If anybody has a better solution for the bug, please also go ahead and
>> I'll be happy to just drop my patches.
>>
>> Thanks in advance and best regards,
>> Michael
>>
>> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=25893
> 
> Hi Michael,
> 
> Thanks for the patches.  You've sent the patches using git-send-email, so that's
> already a very good start :).
> 
> For your copyright assignment, if you haven't started the process already, take
> a look at this form.  The instructions are included.
> 
>   http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future
> 
> We'll try to review your patches soon, but given the volume of patches, there can
> be some delay.  If you have no response after two weeks, please ping your patchset,
> and then weekly after that.  That will keep it alive.
> 
> Thanks,
> 
> Simon
> 

Hi Simon,

thanks. :)

I have now filled the form and sent it to assign@gnu.org.

Best regards,
Michael


  reply	other threads:[~2020-04-30  6:04 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 11:16 Michael Weghorn
2020-04-29 11:16 ` [PATCH 0/4] gdb: Move construct_inferior_arguments to gdbsupport Michael Weghorn
2020-05-07 19:31   ` Simon Marchi
2020-05-12 15:50     ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases Michael Weghorn
2020-04-29 15:25   ` Christian Biesinger
2020-04-29 15:45     ` Christian Biesinger
2020-05-07 19:29       ` Simon Marchi
2020-05-12 15:48         ` Michael Weghorn
2020-05-12 16:11           ` Simon Marchi
2020-05-12 16:24             ` Michael Weghorn
2020-04-30  6:02     ` [PATCH v2 " Michael Weghorn
2020-05-07 19:49       ` Simon Marchi
2020-05-12 15:57         ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 2/4] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-07 19:54   ` Simon Marchi
2020-05-12 16:00     ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 3/4] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-07 20:09   ` Simon Marchi
2020-05-07 22:09     ` Simon Marchi
2020-05-12 16:10       ` Michael Weghorn
2020-05-12 16:07     ` Michael Weghorn
2020-05-12 17:37       ` Simon Marchi
2020-05-13  1:59         ` Simon Marchi
2020-05-13  9:51           ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 4/4] [PR gdbserver/25893]: Add gdbserver test for argument with space in it Michael Weghorn
2020-05-07 22:15   ` Simon Marchi
2020-05-10 15:59     ` [PATCH 1/2] gdb/testsuite: support passing inferior arguments with native-gdbserver board Simon Marchi
2020-05-10 15:59       ` [PATCH 2/2] gdb/testsuite: add inferior arguments test Simon Marchi
2020-05-15 20:07         ` Pedro Alves
2020-05-19 17:13           ` Simon Marchi
2020-05-20 16:28             ` Michael Weghorn
2020-05-15 20:07       ` [PATCH 1/2] gdb/testsuite: support passing inferior arguments with native-gdbserver board Pedro Alves
2020-05-10 16:09     ` [PATCH 4/4] [PR gdbserver/25893]: Add gdbserver test for argument with space in it Simon Marchi
2020-05-11 14:33       ` Michael Weghorn
2020-05-11 15:04         ` Simon Marchi
2020-05-12 16:20           ` Michael Weghorn
2020-05-12 16:50             ` Simon Marchi
2020-05-13  9:55               ` Michael Weghorn
2020-04-29 15:27 ` Patches for PR 25893 "gdbserver incorrectly handles program args containing space" Simon Marchi
2020-04-30  6:03   ` Michael Weghorn [this message]
2020-05-12 15:42 ` [PATCH v3 1/6] gdb: Move construct_inferior_arguments to gdbsupport Michael Weghorn
2020-05-12 15:42   ` [PATCH v3 2/6] gdbsupport: Adapt construct_inferior_arguments Michael Weghorn
2020-05-12 17:53     ` Simon Marchi
2020-05-13  9:56       ` Michael Weghorn
2020-05-12 15:42   ` [PATCH v3 3/6] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-12 15:42   ` [PATCH v3 4/6] nto_process_target::create_inferior: Pass args as char ** Michael Weghorn
2020-05-12 18:34     ` Simon Marchi
2020-05-13  9:56       ` Michael Weghorn
2020-05-12 15:42   ` [PATCH v3 5/6] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-13  0:52     ` Simon Marchi
2020-05-13  0:54       ` Simon Marchi
2020-05-13  9:58         ` Michael Weghorn
2020-05-12 15:42   ` [PATCH v3 6/6] gdbsupport: Drop now unused function 'stringify_argv' Michael Weghorn
2020-05-13  0:52     ` Simon Marchi
2020-05-13  9:47 ` [PATCH v4 1/9] gdb: Move construct_inferior_arguments to gdbsupport Michael Weghorn
2020-05-13  9:47   ` [PATCH v4 2/9] gdbsupport: Adapt construct_inferior_arguments Michael Weghorn
2020-05-13  9:47   ` [PATCH v4 3/9] gdbsupport: Let construct_inferior_arguments take gdb::array_view param Michael Weghorn
2020-05-13  9:47   ` [PATCH v4 4/9] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-13  9:47   ` [PATCH v4 5/9] nto_process_target::create_inferior: Pass args as char ** Michael Weghorn
2020-05-13  9:47   ` [PATCH v4 6/9] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-13  9:47   ` [PATCH v4 7/9] gdbsupport: Drop now unused function 'stringify_argv' Michael Weghorn
2020-05-13  9:47   ` [PATCH v4 8/9] gdb/testsuite: support passing inferior arguments with native-gdbserver board Michael Weghorn
2020-05-15 17:29     ` Tom de Vries
2020-05-19 17:11       ` Simon Marchi
2020-05-19 17:22         ` Simon Marchi
2020-05-19 18:46           ` Tom de Vries
2020-05-25 15:14             ` Simon Marchi
2020-05-13  9:47   ` [PATCH v4 9/9] gdb/testsuite: add inferior arguments test Michael Weghorn
2020-05-13 14:39   ` [PATCH v4 1/9] gdb: Move construct_inferior_arguments to gdbsupport Simon Marchi
2020-05-13 15:01     ` Michael Weghorn
2020-05-13 15:05       ` Simon Marchi
2020-05-20 16:37         ` Michael Weghorn
2020-05-20 16:40           ` Simon Marchi
2020-05-20 16:21 ` [PATCH v5 " Michael Weghorn
2020-05-20 16:21   ` [PATCH v5 2/9] gdbsupport: Adapt construct_inferior_arguments Michael Weghorn
2020-05-20 16:21   ` [PATCH v5 3/9] gdbsupport: Let construct_inferior_arguments take gdb::array_view param Michael Weghorn
2020-05-20 16:21   ` [PATCH v5 4/9] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-20 16:21   ` [PATCH v5 5/9] nto_process_target::create_inferior: Pass args as char ** Michael Weghorn
2020-05-20 16:21   ` [PATCH v5 6/9] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-20 16:21   ` [PATCH v5 7/9] gdbsupport: Drop now unused function 'stringify_argv' Michael Weghorn
2020-05-20 16:21   ` [PATCH v5 8/9] gdb/testsuite: support passing inferior arguments with native-gdbserver board Michael Weghorn
2020-05-20 16:21   ` [PATCH v5 9/9] gdb/testsuite: add inferior arguments test Michael Weghorn
2020-05-25 15:42   ` [PATCH v5 1/9] gdb: Move construct_inferior_arguments to gdbsupport Simon Marchi
2020-05-26  6:17     ` Michael Weghorn
2021-09-28 14:33       ` Simon Marchi via Gdb-patches
2021-09-29  5:53         ` Michael Weghorn via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d6f478-7692-a5ba-1ab4-1707e9dccd0e@posteo.de \
    --to=m.weghorn@posteo.de \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox