From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128745 invoked by alias); 19 Sep 2018 14:16:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128539 invoked by uid 89); 19 Sep 2018 14:15:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=person X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 14:15:18 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w8JEF2GL020185 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 19 Sep 2018 10:15:07 -0400 Received: by simark.ca (Postfix, from userid 112) id 89FBA1E76F; Wed, 19 Sep 2018 10:15:02 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 14EA81E175; Wed, 19 Sep 2018 10:15:00 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 19 Sep 2018 14:16:00 -0000 From: Simon Marchi To: Joel Brobecker Cc: Tom Tromey , Xavier Roirand , gdb-patches@sourceware.org Subject: Re: [RFA 2/5] Darwin: Handle unrelocated dyld. In-Reply-To: <20180919134057.GN19172@adacore.com> References: <1534932677-9496-1-git-send-email-roirand@adacore.com> <1534932677-9496-3-git-send-email-roirand@adacore.com> <18e995c1bee8c82df212dd431136d259@polymtl.ca> <87lg7ysdpb.fsf@tromey.com> <20180919134057.GN19172@adacore.com> Message-ID: <87d657aa82a5a114995d8035c4f2f125@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00684.txt.bz2 On 2018-09-19 09:40, Joel Brobecker wrote: > That makes me realize (again) that, for MacOS X, we should be more > proactive at specificying which version a patch we are submitting > was tested on, and some information about which versions of MacOS X > a given patch helps. A fair amount of work that Tristan did once > the initial port was created was to adapt it to subsequent versions > of Darwin. Nearly every new version of Darwin introduced its new > set of changes requiring additional adaptations. Given the low amount of resources we have to work on GDB for macOS and the fact that it's difficult for one person to test on different versions of macOS (you would need multiple Mac computers, AFAIK), I suggest that we only aim at supporting the last two released versions of macOS. I say two, because there will always be an overlap after a new version is released, where some people use the new version and others have not upgraded yet. If some people use older versions of macOS and want to contribute patches and help testing, that's fine too, but if everybody contributing is on latest or latest-1, we can't realistically ensure it works on previous versions. That said, I agree that it would be very helpful if commit messages and comments in the code mentioned the version of macOS that was used at the time that commit message or comment was written. Simon