Re: [PATCH] cd command defaults to ~

Jan Kratochvil
2012-07-22T16:50:16Z

On Sun, 22 Jul 2012 18:37:04 +0200, Nathaniel Flath wrote:
> Whoops, missed this email for a bit.

> +2012-07-21 Nathaniel Flath <flat0103@gmail.com>
> + * cli-cmds.c (cd_command) changed default argument to '~'.

This is not a real ChangeLog, see other entries plus:
http://www.gnu.org/prep/standards/standards.html#Change-Logs

BTW it is better not to modify the ChangeLog file(s) itself but write is as
a text along the patch, the repository ChangeLog file(s) as constantly
changing.

Your ChangeLog should have been, including the spacing:

gdb/
2012-07-21 Nathaniel Flath <flat0103@gmail.com>

* NEWS: New entry for 'cd' default parameters.
* cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment.

doc/
2012-07-21 Nathaniel Flath <flat0103@gmail.com>

* gdb.texinfo (Working Directory): <FIXME>

But the doc patch part does not seem to be right to me (although authoritative
is Eli). I would probably create a new entry besides 'cd DIRECTORY' and 'pwd'
also 'cd' (without DIRECTORY). Or one can modify 'cd DIRECTORY'
to be 'cd [DIRECTORY]' instead.

I guess Tom assumes no FSF copyright assignment is needed for this patch, Tom?

Thanks,
Jan