Re: [PATCH] cd command defaults to ~

Nathaniel Flath
2012-08-06T09:15:15Z

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

Thanks,
Nathaniel Flath

ChangeLog
gdb/
2012-07-21 Nathaniel Flath <flat0103@gmail.com>

* NEWS: New entry for 'cd' default parameters.
* cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment.

doc/
2012-07-21 Nathaniel Flath <flat0103@gmail.com>

* gdb.texinfo (Working Directory): Added information about new
default argument for 'cd' command.

On Mon, Aug 6, 2012 at 1:54 AM, Nathaniel Flath <flat0103@gmail.com> wrote:
>
> Here it is, with the patch attached.
>
>
> Thanks,
> Nathaniel Flath
>
>
>
> ChangeLog
> gdb/
> 2012-07-21 Nathaniel Flath <flat0103@gmail.com>
>
> * NEWS: New entry for 'cd' default parameters.
> * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment.
>
> doc/
> 2012-07-21 Nathaniel Flath <flat0103@gmail.com>
>
> * gdb.texinfo (Working Directory): Added information about new
> default argument for 'cd' command.
>
>
> On Sat, Aug 4, 2012 at 11:27 AM, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> > On Sat, 04 Aug 2012 20:16:32 +0200, Nathaniel Flath wrote:
> >> Is there anything else I need to do, anyone?
> >
> > The patch is not applicable:
> > patching file NEWS
> > patch: **** malformed patch at line 34: * GDB now supports x32 ABI. Visit <http://sites.google.com/site/x32abi/>
> >
> > Unaware why. Most probably the issue gets resolved if you attach the patch
> > (and not inline it). It would be better to reconfigure your MUA so that the
> > inserted patch info mail text is not corrupted.
> >
> >
> > Thanks,
> > Jan
>

[-- Attachment #2: cd.patch --]
[-- Type: application/octet-stream, Size: 1579 bytes --]

Index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.533
diff -u -r1.533 NEWS
--- NEWS 4 Jul 2012 20:49:56 -0000 1.533
+++ NEWS 6 Aug 2012 08:51:48 -0000
@@ -3,6 +3,9 @@

*** Changes since GDB 7.4

+* The 'cd' command now defaults to using '~' (the home directory) if not
+ given an argument.
+
* GDB now supports x32 ABI. Visit <http://sites.google.com/site/x32abi/>
for more x32 ABI info.

Index: cli/cli-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
retrieving revision 1.131
diff -u -r1.131 cli-cmds.c
--- cli/cli-cmds.c 13 Jun 2012 15:47:15 -0000 1.131
+++ cli/cli-cmds.c 6 Aug 2012 08:51:48 -0000
@@ -367,7 +367,7 @@
dont_repeat ();

if (dir == 0)
- error_no_arg (_("new working directory"));
+ dir = "~";

dir = tilde_expand (dir);
make_cleanup (xfree, dir);
Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.990
diff -u -r1.990 gdb.texinfo
--- doc/gdb.texinfo 5 Jul 2012 01:08:24 -0000 1.990
+++ doc/gdb.texinfo 6 Aug 2012 08:51:49 -0000
@@ -2274,8 +2274,9 @@
@table @code
@kindex cd
@cindex change working directory
-@item cd @var{directory}
-Set the @value{GDBN} working directory to @var{directory}.
+@item cd @r{[}@var{directory}@r{]}
+Set the @value{GDBN} working directory to @var{directory}. If not
+given, @var{directory} uses @file{'~'}.

@kindex pwd
@item pwd