Re: [PATCH] cd command defaults to ~

Nathaniel Flath
2012-08-04T05:55:29Z

Sorry for the late reply again.

In any case, I've done FSF assignment for Emacs.

Patch w/ recommended updates follows:

ChangeLog
gdb/
2012-07-21 Nathaniel Flath <flat0103@gmail.com>

* NEWS: New entry for 'cd' default parameters.
* cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment.

doc/
2012-07-21 Nathaniel Flath <flat0103@gmail.com>

* gdb.texinfo (Working Directory): Added information about new
default argument for 'cd' command.

index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.533
diff -u -r1.533 NEWS
--- NEWS 4 Jul 2012 20:49:56 -0000 1.533
+++ NEWS 7 Jul 2012 04:28:05 -0000
@@ -3,6 +3,8 @@

*** Changes since GDB 7.4

+* The 'cd' command now defaults to using '~'(the home directory) if
not given an argument.
+
* GDB now supports x32 ABI. Visit <http://sites.google.com/site/x32abi/>
for more x32 ABI info.

Index: cli/cli-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
retrieving revision 1.131
diff -u -r1.131 cli-cmds.c
--- cli/cli-cmds.c 13 Jun 2012 15:47:15 -0000 1.131
+++ cli/cli-cmds.c 7 Jul 2012 04:28:05 -0000
@@ -367,7 +367,7 @@
dont_repeat ();

if (dir == 0)
- error_no_arg (_("new working directory"));
+ dir = "~";

dir = tilde_expand (dir);
make_cleanup (xfree, dir);
Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.990
diff -u -r1.990 gdb.texinfo
--- doc/gdb.texinfo 5 Jul 2012 01:08:24 -0000 1.990
+++ doc/gdb.texinfo 7 Jul 2012 04:28:06 -0000
@@ -2275,7 +2275,8 @@
@kindex cd
@cindex change working directory
-@item cd @var{directory}
-Set the @value{GDBN} working directory to @var{directory}.
+@item cd @r{[}@var{directory}@r{]}
+Set the @value{GDBN} working directory to @var{directory}. If not
+given, +@var{directory} uses @file'~'.

@kindex pwd
@item pwd

On Mon, Jul 23, 2012 at 7:13 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> I guess Tom assumes no FSF copyright assignment is needed for this
> Jan> patch, Tom?
>
> I think it is small enough.
>
> Tom