RE: [patch v3 01/16] gdbserver, build: add -DGDBSERVER

Metzger, Markus T
2012-08-15T07:59:31Z

> -----Original Message-----
> From: Doug Evans [mailto:dje@google.com]
> Sent: Wednesday, August 15, 2012 2:41 AM

Thanks for your review!

[...]

> > +# Let all files know we're compiling for gdbserver.
> > +INTERNAL_CFLAGS += -DGDBSERVER

[...]

> "+=" is a GNU make-ism, I think we can't use it here.
>
> Plus you missed one:
>
> gdb_vecs.o: ../common/gdb_vecs.c $(vec_h) $(gdb_vecs_h) $(host_defs_h)
> $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< -DGDBSERVER

Fixed both. Gdb/common is growing very fast - that's good. I'll send an updated patch.

Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer, Christian Lamprechter
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052