Re: [patch v3 01/16] gdbserver, build: add -DGDBSERVER

Doug Evans
2012-08-15T00:41:35Z

On Tue, Aug 14, 2012 at 5:59 AM, <markus.t.metzger@intel.com> wrote:
> From: Markus Metzger <markus.t.metzger@intel.com>
>
> A use of common/vec.h in gdbserver may result in compile errors if GDBSERVER is
> not defined.
>
> Add -DGDBSERVER to all gdbserver cflags.
>
> 2012-08-14 Markus Metzger <markus.t.metzger@intel.com>
>
> gdbserver/
> * Makefile.in: (INTERNAL_CFLAGS): Add -DGDBSERVER
> (various make rules): Remove -DGDBSERVER
>
>
> ---
> gdb/gdbserver/Makefile.in | 27 +++++++++++++++------------
> 1 files changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
> index f62799e..ae5a60e 100644
> --- a/gdb/gdbserver/Makefile.in
> +++ b/gdb/gdbserver/Makefile.in
> @@ -113,6 +113,9 @@ INTERNAL_CFLAGS_BASE = ${CFLAGS} ${GLOBAL_CFLAGS} \
> INTERNAL_WARN_CFLAGS = ${INTERNAL_CFLAGS_BASE} $(WARN_CFLAGS)
> INTERNAL_CFLAGS = ${INTERNAL_WARN_CFLAGS} $(WERROR_CFLAGS)
>
> +# Let all files know we're compiling for gdbserver.
> +INTERNAL_CFLAGS += -DGDBSERVER
> +
> # LDFLAGS is specifically reserved for setting from the command line
> # when running make.
> LDFLAGS = @LDFLAGS@
> @@ -447,7 +450,7 @@ UST_CFLAGS = $(ustinc) -DCONFIG_UST_GDB_INTEGRATION
> # Note, we only build the IPA if -fvisibility=hidden is supported in
> # the first place.
> IPAGENT_CFLAGS = $(CPPFLAGS) $(INTERNAL_CFLAGS) $(UST_CFLAGS) \
> - -fPIC -DGDBSERVER -DIN_PROCESS_AGENT \
> + -fPIC -DIN_PROCESS_AGENT \
> -fvisibility=hidden

"+=" is a GNU make-ism, I think we can't use it here.

Plus you missed one:

gdb_vecs.o: ../common/gdb_vecs.c $(vec_h) $(gdb_vecs_h) $(host_defs_h)
$(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< -DGDBSERVER