Re: [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects.

Eli Zaretskii
2012-09-18T06:59:49Z

> From: Sanjoy Das <sanjoy@playingwithpointers.com>
> Cc: Sanjoy Das <sanjoy@playingwithpointers.com>
> Date: Tue, 18 Sep 2012 10:04:06 +0530
>
> +@item jit-reader-load @var{reader}
> +Load the JIT reader named @var{reader}. @var{reader} can either be
> +the absolute path to or the file name of a shared object.

GNU coding standards discourage using "path" to mean a file name. So
I suggest to rephrase:

@var{reader} is a shared object specified as either an absolute or
a relative file name.

> +Only one reader can be active at a time; trying to load a second
> +reader when one is already loaded will result in @value{GDBN}
> +reporting an error. A new JIT reader can be loaded by first unloading
> +the current one using @code{jit-reader-load} and then invoking
> +@code{jit-reader-load}. ^^^^^^^^^^^^^^^

"jit-reader-unload", I presume. (Yes, I know you were only copying
the existing mistake.)

The documentation parts are OK with those changes.

> + if (args[0] == '/')

Why not use IS_ABSOLUTE_PATH here? That would make the code more
portable.

Thanks.