From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10475 invoked by alias); 18 Sep 2012 19:36:35 -0000 Received: (qmail 10377 invoked by uid 22791); 18 Sep 2012 19:36:34 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 19:36:19 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8IJaIEi029993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Sep 2012 15:36:18 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8IJaHBF006068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 18 Sep 2012 15:36:17 -0400 From: Tom Tromey To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface. References: <1347942847-31510-1-git-send-email-sanjoy@playingwithpointers.com> <1347942847-31510-4-git-send-email-sanjoy@playingwithpointers.com> Date: Tue, 18 Sep 2012 19:36:00 -0000 In-Reply-To: <1347942847-31510-4-git-send-email-sanjoy@playingwithpointers.com> (Sanjoy Das's message of "Tue, 18 Sep 2012 10:04:07 +0530") Message-ID: <87d31jw2bz.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00376.txt.bz2 >>>>> "Sanjoy" == Sanjoy Das writes: Sanjoy> +2012-09-18 Sanjoy Das Thanks. This is very nice. Sanjoy> + * gdb.base/jit-reader.exp (new): Test case for the jit-reader Sanjoy> + interface. Sanjoy> + * gdb.base/jithost.c (new): Do. Sanjoy> + * gdb.base/jithost.h (new): Do. Sanjoy> + * gdb.base/jitreader.c (new) : Do. Those should be like: * gdb.base/jithost.c: New file. Sanjoy> +# Note: compiling without debug info: the library goes through symbol Sanjoy> +# renaming by munging on its symbol table, and that wouldn't work for .debug Sanjoy> +# sections. Also, output for "info function" changes when debug info is resent. Bad copy&paste :) I think this comment isn't relevant & can be deleted. Sanjoy> + gdb_test "run" ".*" Use gdb_run_cmd instead. Tom