From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98414-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21015 invoked by alias); 11 Feb 2013 21:33:53 -0000
Received: (qmail 20995 invoked by uid 22791); 11 Feb 2013 21:33:53 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Feb 2013 21:33:49 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1BLXmLJ009771	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 11 Feb 2013 16:33:48 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1BLXlAj008150	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 11 Feb 2013 16:33:48 -0500
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] split up ui_printf, fix decfloat printing bugs
References: <yjt2txpmo000.fsf@ruffy2.mtv.corp.google.com>
Date: Mon, 11 Feb 2013 21:33:00 -0000
In-Reply-To: <yjt2txpmo000.fsf@ruffy2.mtv.corp.google.com> (Doug Evans's	message of "Fri, 08 Feb 2013 15:32:15 -0800")
Message-ID: <87d2w6pmbo.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00264.txt.bz2

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> I don't understand this code in ui_printf:
[...]
Doug> It makes no sense given that the format string is parsed into pieces.
Doug> Am I missing something?

I don't understand it either.
I also think it is wrong as-is.

Doug> Regression tested on amd64-linux.
Doug> Ok to check in?

Looks good to me.

Tom