From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23582 invoked by alias); 20 May 2014 15:10:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23565 invoked by uid 89); 20 May 2014 15:10:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 May 2014 15:10:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4KFATcc027770 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 20 May 2014 11:10:29 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4KFA480024050 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 20 May 2014 11:10:10 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix TLS access for -static -pthread References: <20140410115204.GB16411@host2.jankratochvil.net> Date: Tue, 20 May 2014 15:10:00 -0000 In-Reply-To: <20140410115204.GB16411@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 10 Apr 2014 13:52:04 +0200") Message-ID: <87d2f8trjo.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00426.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> I have posted: Jan> TLS variables access for -static -lpthread executables Jan> https://sourceware.org/ml/libc-help/2014-03/msg00024.html Jan> and the GDB patch below has been confirmed as OK for current glibcs. Jan> + /* GNU __libc_setup_tls initializes l_tls_modid as 1. */ Jan> + err = info->td_thr_tlsbase_p (&thread_info->private->th, Jan> + 1, &address); This bit of code (and another like it later on) should have a longer comment, probably at least including the link above, but also some text about how this is a hack but why it is ok. Otherwise this is ok. Tom