From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3228 invoked by alias); 25 Nov 2014 02:50:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3216 invoked by uid 89); 25 Nov 2014 02:50:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,UNSUBSCRIBE_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Nov 2014 02:50:24 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1Xt6Cr-0005Gf-N6 from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 24 Nov 2014 18:50:21 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.181.6; Mon, 24 Nov 2014 18:50:21 -0800 From: Yao Qi To: Sandra Loosemore CC: Subject: Re: [1/3 patch, nios2] clean up prologue/epilogue detection code, v2 References: <545EA0C1.6050104@codesourcery.com> <87bnoeif74.fsf@codesourcery.com> <5473C4BA.2050903@codesourcery.com> <5473C72B.4000801@codesourcery.com> Date: Tue, 25 Nov 2014 02:50:00 -0000 In-Reply-To: <5473C72B.4000801@codesourcery.com> (Sandra Loosemore's message of "Mon, 24 Nov 2014 17:02:51 -0700") Message-ID: <87d28cdmdl.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00619.txt.bz2 Sandra Loosemore writes: > This part of the revised Nios II prologue/epilogue refactoring patch > set includes only the parts that introduce new helper functions to > match and disassemble instructions. OK to commit, this time? > > -Sandra > > 2014-11-24 Sandra Loosemore > > gdb/ > * nios2-tdep.c (nios2_fetch_insn): Move up in file. Disassemble > the instruction as well as reading it from memory. > (nios2_match_add): New. > (nios2_match_sub): New. > (nios2_match_addi): New. > (nios2_match_orhi): New. > (nios2_match_stw): New. > (nios2_match_ldw): New. > (nios2_match_rdctl): New. > (enum branch_condition): New. > (nios2_match_branch): New. > (nios2_match_jmpi): New. > (nios2_match_calli): New. > (nios2_match_jmpr): New. > (nios2_match_callr): New. > (nios2_match_break): New. > (nios2_match_trap): New. > (nios2_in_epilogue_p): Rewrite to use new functions. > (nios2_analyze_prologue): Likewise. > (nios2_skip_prologue): Delete unused local limit_pc. > (nios2_breakpoint_from_pc): Make R1-specific encodings explicit. > (nios2_get_next_pc): Rewrite to use new functions. This is OK. --=20 Yao (=E9=BD=90=E5=B0=A7)