From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66550 invoked by alias); 28 Nov 2016 23:08:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66523 invoked by uid 89); 28 Nov 2016 23:08:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_PSBL,SPF_PASS autolearn=no version=3.3.2 spammy=afaict, AFAICT, H*F:U*tom, H*r:57600 X-HELO: gproxy4-pub.mail.unifiedlayer.com Received: from gproxy4-pub.mail.unifiedlayer.com (HELO gproxy4-pub.mail.unifiedlayer.com) (69.89.23.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 28 Nov 2016 23:08:01 +0000 Received: (qmail 6013 invoked by uid 0); 28 Nov 2016 23:07:59 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy4.mail.unifiedlayer.com with SMTP; 28 Nov 2016 23:07:59 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id Db7v1u00H2f2jeq01b7yKr; Mon, 28 Nov 2016 16:07:58 -0700 X-Authority-Analysis: v=2.1 cv=E8Je+8tl c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=20KFwNOVAAAA:8 a=MOylThLhKSBtQGj8VT4A:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 71-218-195-233.hlrn.qwest.net ([71.218.195.233]:57600 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cBV1g-0002px-Md; Mon, 28 Nov 2016 16:07:56 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 08/13] Use gdbpy_ref in python.c References: <1479674496-14000-1-git-send-email-tom@tromey.com> <1479674496-14000-9-git-send-email-tom@tromey.com> <440c1b99-6cbe-5718-90f2-c7f0215be999@redhat.com> Date: Mon, 28 Nov 2016 23:08:00 -0000 In-Reply-To: <440c1b99-6cbe-5718-90f2-c7f0215be999@redhat.com> (Pedro Alves's message of "Tue, 22 Nov 2016 17:21:30 +0000") Message-ID: <87d1hfxkxk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cBV1g-0002px-Md X-Source-Sender: 71-218-195-233.hlrn.qwest.net (bapiya) [71.218.195.233]:57600 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-11/txt/msg00926.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> Additionally, previously gdbpy_apply_type_printers would return >> EXT_LANG_RC_ERROR if a type printer returned None. However, that >> doesn't seem correct to me; this patch changes it to return >> EXT_LANG_RC_NOP in this case. Pedro> Agreed, this is what the value printers do, AFAICT from Pedro> gdbpy_apply_val_pretty_printer. Pedro> Does that result in user/script-visible behavior? Should Pedro> this be covered by some test? The caller is apply_ext_lang_type_printers and it does: ALL_ENABLED_EXTENSION_LANGUAGES (i, extlang) ... switch (rc) { ... case EXT_LANG_RC_ERROR: return NULL; case EXT_LANG_RC_NOP: break; So, error means all the subsequent printer will be skipped, but nop means they will be considered. I think a test case would be reasonable, but I would rather not write it. I'm going to push this series in, but if you think the test is required, I will write a follow-up patch to just revert this bit to the status quo ante. Tom