From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34079 invoked by alias); 20 Dec 2016 18:13:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34066 invoked by uid 89); 20 Dec 2016 18:13:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*f:sk:7f11b7b, H*i:sk:7f11b7b X-HELO: gproxy1.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Dec 2016 18:13:00 +0000 Received: from cmgw2 (cmgw3 [10.0.90.83]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id BB16017CA5A for ; Tue, 20 Dec 2016 11:07:37 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id NJ7Y1u01D2f2jeq01J7b8s; Tue, 20 Dec 2016 11:07:36 -0700 X-Authority-Analysis: v=2.1 cv=KYpB72oD c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n5n_aSjo0skA:10 a=20KFwNOVAAAA:8 a=SSEBxaLJx3q6AOKSWtMA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 75-171-175-27.hlrn.qwest.net ([75.171.175.27]:56128 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cJOp4-0006Xp-7L; Tue, 20 Dec 2016 11:07:34 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 7/8] Use unique_xmalloc_ptr in execute_gdb_command References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-8-git-send-email-tom@tromey.com> <878ts2yi5m.fsf@tromey.com> <87inqletsw.fsf@tromey.com> <7f11b7bb-bebb-1cd3-1e92-266638272443@redhat.com> Date: Tue, 20 Dec 2016 18:13:00 -0000 In-Reply-To: <7f11b7bb-bebb-1cd3-1e92-266638272443@redhat.com> (Pedro Alves's message of "Tue, 20 Dec 2016 17:48:44 +0000") Message-ID: <87d1gmwk2j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cJOp4-0006Xp-7L X-Source-Sender: 75-171-175-27.hlrn.qwest.net (pokyo) [75.171.175.27]:56128 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-12/txt/msg00361.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> In some other local patch that I hadn't posted, I handled a similar Pedro> situation of save/restoring some global that we don't want to expose Pedro> by making the "make_cleanup_..." function return a scoped_restore, which Pedro> avoids having to create a new class. It seems a bit simpler that Pedro> creating a class to me, and maybe a tiny bit more efficient code-space Pedro> wise (rtti?) Did you consider this approach? I didn't, but I like it, so I'll make this change. Tom