From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78757 invoked by alias); 9 Feb 2017 00:02:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78676 invoked by uid 89); 9 Feb 2017 00:02:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Zaretskii, zaretskii, H*i:sk:8360kk6, H*f:sk:8360kk6 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Feb 2017 00:02:26 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 03FD261BB5; Thu, 9 Feb 2017 00:02:26 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1902OIC016624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 8 Feb 2017 19:02:25 -0500 From: Sergio Durigan Junior To: Eli Zaretskii Cc: gdb-patches@sourceware.org, palves@redhat.com, lgustavo@codesourcery.com Subject: Re: [PATCH v3 6/6] Implement proper "startup-with-shell" support on gdbserver References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170208032257.15443-1-sergiodj@redhat.com> <20170208032257.15443-7-sergiodj@redhat.com> <8360kk60zn.fsf@gnu.org> X-URL: http://blog.sergiodj.net Date: Thu, 09 Feb 2017 00:02:00 -0000 In-Reply-To: <8360kk60zn.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 Feb 2017 19:33:48 +0200") Message-ID: <87d1es44fk.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00210.txt.bz2 On Wednesday, February 08 2017, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: Pedro Alves , Luis Machado , Sergio Durigan Junior >> Date: Tue, 7 Feb 2017 22:22:57 -0500 >> >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 21e8cd3..f26e95e 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -3,6 +3,13 @@ >> >> *** Changes since GDB 7.12 >> >> +* GDBserver is now able to start inferiors using a shell. When using >> + "target extended-remote", the host GDB honors the value of "set >> + startup-with-shell" in order to inform GDBserver whether the remote >> + inferior should be started with a shell or not. When using "target >> + remote", it is possible to disable the startup with shell by using >> + the new parameter "--no-startup-with-shell" when starting GDBserver. >> + >> * Building GDB and GDBserver now requires a C++11 compiler. >> >> For example, GCC 4.8 or later. >> @@ -367,6 +374,9 @@ show max-value-size >> >> * New remote packets >> >> +QStartupWithShell >> + Indicates whether the inferior must be started with a shell or not. >> + >> exec stop reason >> Indicates that an exec system call was executed. > > This part is OK. > >> +If @var{value} is @var{0}, @command{gdbserver} will not use a shell to >> +start the inferior. If @var{value} is @var{1}, @command{gdbserver} > > "0" and "1" should be in @samp, not @var, because they are literal > symbols. > >> +@item E @var{nn} >> +An error occurred. The error number @var{nn} is give as hex digits. > ^^^^ > "given" > > Documentation patch is OK with those minor issues fixed. Thanks, I fixed the minor issues you pointed. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/