From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13111 invoked by alias); 10 Apr 2017 23:20:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12819 invoked by uid 89); 10 Apr 2017 23:20:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 10 Apr 2017 23:20:18 +0000 Received: (qmail 7302 invoked by uid 0); 10 Apr 2017 23:20:18 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 10 Apr 2017 23:20:18 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 6nLF1v0032f2jeq01nLJrv; Mon, 10 Apr 2017 17:20:18 -0600 X-Authority-Analysis: v=2.2 cv=cpDrqxwi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=IFePfMOmHPL-E_RZKzUA:9 Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:54366 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cxibW-0000Ln-RX; Mon, 10 Apr 2017 17:20:14 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 06/14] Remove cleanup_iconv References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-7-tom@tromey.com> <20f3123507be4351238bda8e0141958f@polymtl.ca> Date: Mon, 10 Apr 2017 23:20:00 -0000 In-Reply-To: <20f3123507be4351238bda8e0141958f@polymtl.ca> (Simon Marchi's message of "Sun, 09 Apr 2017 23:54:51 -0400") Message-ID: <87d1cjzw7m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cxibW-0000Ln-RX X-Source-Sender: 75-166-65-226.hlrn.qwest.net (bapiya) [75.166.65.226]:54366 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-04/txt/msg00251.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> From what I understand about C++ constructors and destructors, the Simon> check for -1 is unnecessary. The destructor will only be called if Simon> the constructor ran to completion. If the constructor ran to Simon> completion (didn't throw), m_desc won't be -1. Yeah, that was just copy-paste from the other class, which may be wrong. I changed this. Tom