From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93593 invoked by alias); 13 Apr 2017 18:26:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93574 invoked by uid 89); 13 Apr 2017 18:26:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Thursday, thursday X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Apr 2017 18:26:45 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1AED77F7C0; Thu, 13 Apr 2017 18:26:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1AED77F7C0 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1AED77F7C0 Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E39EE60E3E; Thu, 13 Apr 2017 18:26:45 +0000 (UTC) From: Sergio Durigan Junior To: Luis Machado Cc: GDB Patches Subject: Re: [PATCH] Make environ.exp run on all platforms (and create info-program.exp) References: <20170331172901.23402-1-sergiodj@redhat.com> Date: Thu, 13 Apr 2017 18:26:00 -0000 In-Reply-To: (Luis Machado's message of "Thu, 13 Apr 2017 09:35:33 -0500") Message-ID: <87d1cgtb8a.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00446.txt.bz2 Thanks for the review, Luis. On Thursday, April 13 2017, Luis Machado wrote: > On 03/31/2017 12:29 PM, Sergio Durigan Junior wrote: >> This has been on my TODO list for a while. There's a really old bug >> about this (PR testsuite/8595), and there was no reason for >> environ.exp to be specific for hppa* targets. So this patch removes >> this constraint, modernizes the testcase, and cleans up some things. >> Most of the tests remained, and some were rewritten (especially the >> one that checks if "show environment" works, which is something kind >> of hard to do). >> >> As a bonus, I'm adding a separated info-program.exp file containing >> all the tests related to "info program" that were present on >> environ.exp. >> >> Tested locally, everything still passes. > > I haven't gone through the entire patch, but i have a question. Was > this exercised for bare-metal? Nope, I haven't had the chance to test this on bare-metal. > If not, please make sure this test works correctly on bare-metal > targets before assuming it does just because it passes on Linux-hosted > tests. Otherwise we may have spurious failures due to tests that are > not supposed to be executed in a bare-metal environment. > > If you don't have access to bare-metal testing, i could give this a > try (it may take a couple days though) and report back. I don't think I have access to a bare-metal easily; if you could test this, I'd really appreciate. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/