From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21664 invoked by alias); 21 Jun 2017 20:34:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21653 invoked by uid 89); 21 Jun 2017 20:34:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 20:34:57 +0000 From: Sergio Durigan Junior To: Simon Marchi Cc: Subject: Re: [PATCH 3/4] dtrace-probe: Put semicolon after while on its own line References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> <1498076108-29914-4-git-send-email-simon.marchi@ericsson.com> X-URL: https://sergiodj.net Date: Wed, 21 Jun 2017 20:34:00 -0000 In-Reply-To: <1498076108-29914-4-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 21 Jun 2017 22:15:07 +0200") Message-ID: <87d19xcc5t.fsf@sergiodj.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-06/txt/msg00609.txt.bz2 On Wednesday, June 21 2017, Simon Marchi wrote: > clang shows this warning. > > /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: error: while loop has empty body [-Werror,-Wempty-body] > while (*p++ != '\0' && p - strtab < strtab_size); > ^ > /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: note: put the semicolon on a separate line to silence this warning > > Putting the semicolon on its own line is not a big sacrifice to get rid of this > warning. I think it's also useful to keep this, because it can catch errors > like this: > > while (something); > { > ... > } > > although gcc would warn about it in a different way (misleading indentation). > > This warning is already discussed here in the GCC bugzilla: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62184 > > gdb/ChangeLog: > > * dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on > its own line. > --- > gdb/dtrace-probe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c > index 122f8de..9a02694 100644 > --- a/gdb/dtrace-probe.c > +++ b/gdb/dtrace-probe.c > @@ -421,7 +421,8 @@ dtrace_process_dof_probe (struct objfile *objfile, > arg.type_str = xstrdup (p); > > /* Use strtab_size as a sentinel. */ > - while (*p++ != '\0' && p - strtab < strtab_size); > + while (*p++ != '\0' && p - strtab < strtab_size) > + ; /* Silence clang's -Wempty-body warning. */ Lately I've been choosing to explicitly put "continue;" when the body doesn't contain anything, like: while (*p++ != '\0' && p - strtab < strtab_size) continue; I don't know what others think about it, but it would solve this problem and also be more verbose that we're just iterating without a body. > > /* Try to parse a type expression from the type string. If > this does not work then we set the type to `long > -- > 2.7.4 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/