From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90379 invoked by alias); 16 Sep 2017 03:53:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90028 invoked by uid 89); 16 Sep 2017 03:53:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,TRACKER_ID autolearn=no version=3.3.2 spammy=heard X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 16 Sep 2017 03:53:32 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A3BB0129862; Sat, 16 Sep 2017 03:53:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A3BB0129862 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C1A85D96A; Sat, 16 Sep 2017 03:53:30 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches , Yao Qi Subject: Re: [PATCH] Use std::vector on tdesc->reg_defs (gdbserver/tdesc.h) References: <20170910171249.28470-1-sergiodj@redhat.com> Date: Sat, 16 Sep 2017 03:53:00 -0000 In-Reply-To: (Simon Marchi's message of "Sun, 10 Sep 2017 20:43:47 +0200") Message-ID: <87d16r8fk6.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00429.txt.bz2 On Sunday, September 10 2017, Simon Marchi wrote: > On 2017-09-10 19:12, Sergio Durigan Junior wrote: >> This is a followup patch to the build breakage fix on AArch64. While >> doing the fix, I found it better to convert tdesc->reg_defs (on >> gdbserver/tdesc.h) from using VEC to using std::vector. This makes >> the code easier to read and maintain, and also is one more step >> towards the C++fication. >> >> Regtested on BuildBot. > > Hi Sergio, > > Thanks for the patch. It looks good to me, but Yao might want to look > at it since it changes an area he knows well. So leave the patch up > for a few days just in case, if you haven't heard anything new in a > week, you can push. Pushed now. c4dfafabc575f4995a5aa18241adc275e63c846c Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/