Re: [PATCH v4] Add support for the readnever concept

Sergio Durigan Junior
2017-12-01T17:21:33Z

On Friday, December 01 2017, Tom Tromey wrote:

>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> On 12/01/2017 04:35 AM, Sergio Durigan Junior wrote:
>>>> If readnever_symbol_files is set, then it'll have been propagated to
> objfile-> flags before we get here, no?
>>>
>>> Hm, I think so, yes. I mean, assuming that objfile != NULL when we call
>>> the readers, then yes;
>
> Pedro> Certainly you can assume that. A reader's job is to read
> Pedro> in the passed in objfile. The very first line of elf_symfile_read
> Pedro> would immediately crash otherwise, for example.
>
> Perhaps an ATTRIBUTE_NONNULL is in order somewhere.

I thought about a gdb_assert, actually. But yeah, I agree. I'll push
what Pedro has approved, and if he's OK with it, I'll prepare a patch
with a gdb_assert.

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible