Re: possible fix for PR symtab/23010

Sergio Durigan Junior
2018-05-18T00:25:50Z

On Monday, May 07 2018, Joel Brobecker wrote:

> I was wondering if anyone had any thoughts regarding Tom patch.
> https://sourceware.org/ml/gdb-patches/2018-04/msg00234.html
>
> Below are my comments on it, and also my interrogations on whether
> we might want this patch in 8.1.1 or not.
>
> Additional thoughts:
> - This is a regression
> - This is an internal error, so it can be fairly problematic
> - It only happens with -readnow, it seems, which I assume
> is not widely used considering the performance and memory
> cost of this feature.
>
> I might tip in favor of putting it in, considering the fact that
> I don't think there is much of a workaround, but I would not make
> that call just on my own, because the patch is far from obvious.

[ CCing Pedro. ]

Hey Joel,

Just my two cents here. This patch apparently fixes a bunch of bugs
filed against Fedora GDB, which may indicate that either (a) it's not
related only to -readnow, or (b) more people use -readnow than we know
of ;-).

In either case, and speaking without much knowledge of the patch itself,
I think it should be included in 8.1.1. At least I know I will include
it in our Fedora GDB (and well, if Tom is willing to backport it, then
he'll also save me some time!).

Cheers,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible