Re: possible fix for PR symtab/23010

Joel Brobecker
2018-05-14T17:38:44Z

Hi Tom,

On Mon, May 07, 2018 at 10:13:09AM -0700, Joel Brobecker wrote:
> Hello Global Maintainers,
>
> I was wondering if anyone had any thoughts regarding Tom patch.
> https://sourceware.org/ml/gdb-patches/2018-04/msg00234.html
>
> Below are my comments on it, and also my interrogations on whether
> we might want this patch in 8.1.1 or not.
>
> Additional thoughts:
> - This is a regression
> - This is an internal error, so it can be fairly problematic
> - It only happens with -readnow, it seems, which I assume
> is not widely used considering the performance and memory
> cost of this feature.
>
> I might tip in favor of putting it in, considering the fact that
> I don't think there is much of a workaround, but I would not make
> that call just on my own, because the patch is far from obvious.

Considering that the patch has been under review for 1 month, and
has been available for additional comments for a couple of weeks
since my review, and that this patch is a potential for inclusion
in 8.1.1, I propose we rebase, make whatever tiny adjustments that
were discussed, and start by pushing it to master.

As mentioned in my weekly update of the 8.1.1 release, we can then
wait a week or two before deciding whether we want it in 8.1.1 or not.

WDYT?

Thanks!
--
Joel