Re: [PATCH] [PR gdb/23127] [AArch64] Fix tagged pointer support

Omair Javaid
2018-05-25T17:15:14Z

On Fri, 25 May 2018, 10:12 PM H.J. Lu, <hjl.tools@gmail.com> wrote:

> On Fri, May 25, 2018 at 10:11 AM, Sergio Durigan Junior
> <sergiodj@redhat.com> wrote:
> > On Friday, May 25 2018, I wrote:
> >
> >> On Monday, May 21 2018, Omair Javaid wrote:
> >>
> >>> On Mon, 21 May 2018, 9:06 PM H.J. Lu, <hjl.tools@gmail.com> wrote:
> >>>
> >>>> On Wed, May 9, 2018 at 7:19 AM, Pedro Alves <palves@redhat.com>
> wrote:
> >>>> > Hello,
> >>>> >
> >>>> > Thanks much for all the investigation & discussion, both of you.
> >>>> >
> >>>> > On 05/08/2018 10:31 AM, Omair Javaid wrote:
> >>>> >
> >>>> >> I was wondering if you can kindly help review this patch.
> >>>> >> This is a critical bug as it blocks kernel debugging on AArch64.
> >>>> >> Also can we push this to GDB 8.1.1 once it gets accepted?
> >>>> >
> >>>> > Yes, this is OK for both master and branch.
> >>>> >
> >>>> > Please add "PR gdb/23127" to the ChangeLog before pushing.
> >>>> >
> >>>>
> >>>> This breaks gdb on x86-64:
> >>>>
> >>>> https://sourceware.org/bugzilla/show_bug.cgi?id=23210
> >>>>
> >>>>
> >>>>
> >>> Hmm. I ll check it out. Thanks for reporting.
> >>
> >> Hi Omair,
> >>
> >> Any news on this failure? It is causing the testcase to take more than
> >> 14 hours to run when using --target_board=unix/-m32, and is impacting
> >> some of our builders on BuildBot.
> >
> > Apparently you sent a fix already. Sorry about this message.
> >
>
> But the fix is wrong.
>

I will update gdbarch as suggested. Are there any other issues in the fix I
should address.?

>
> --
> H.J.
>