From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11509 invoked by alias); 27 Jul 2018 19:57:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11490 invoked by uid 89); 27 Jul 2018 19:57:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,TRACKER_ID autolearn=no version=3.3.2 spammy=Hx-languages-length:1700 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Jul 2018 19:57:51 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E65828197011; Fri, 27 Jul 2018 19:57:49 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id CBCB52026D6B; Fri, 27 Jul 2018 19:57:49 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Improve gcore manpage and clarify "-o" option References: <20180727050234.20742-1-sergiodj@redhat.com> <831sbptdm3.fsf@gnu.org> Date: Fri, 27 Jul 2018 19:57:00 -0000 In-Reply-To: <831sbptdm3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 27 Jul 2018 09:08:20 +0300") Message-ID: <87d0v8qwn6.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00743.txt.bz2 On Friday, July 27 2018, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: Eli Zaretskii , >> Sergio Durigan Junior >> Date: Fri, 27 Jul 2018 01:02:34 -0400 >> >> Ref.: https://bugs.debian.org/904628 >> >> It has been reported that gcore's manpage is a bit imprecise when it >> comes to two things: >> >> - It doesn't explicity say that the command accepts more than one PID >> on its CLI. >> >> - It fails to mention that the argument passed through the "-o" option >> is actually a prefix that will be used to compose the corefile's >> filename, and not the actual filename. >> >> I decided to give it a try and rewrite parts of the text to further >> clarify these two points. I ended up rewording the "Description" >> section because, IMHO, it was a bit confuse to understand. >> >> To make things consistent, I've also renamed the "$name" variable in >> the gcore.in script, and expanded the usage text. >> >> gdb/doc/ChangeLog: >> yyyy-mm-dd Sergio Durigan Junior >> >> * gdb.texinfo (gcore man): Rewrite "Description" and "-o" >> option sections to further clarify that gcore can take more >> than one PID, and that "-o" is used to specify a prefix, not a >> filename. >> >> gdb/ChangeLog: >> yyyy-mm-dd Sergio Durigan Junior >> >> * gcore.in: Rename variable "name" to "prefix". Expand >> "usage" text. > > This is OK, thanks. Thanks, pushed: 129eb0f1f16dc7a49799a024a7bcb109d954a1e7 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/