From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54632 invoked by alias); 30 Jul 2018 15:05:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54621 invoked by uid 89); 30 Jul 2018 15:05:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HTo:D*cz, laugh X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.62.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Jul 2018 15:05:16 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway20.websitewelcome.com (Postfix) with ESMTP id D2B6C40119F3B for ; Mon, 30 Jul 2018 10:05:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id k9iwfCwplbXuJk9jHfId8P; Mon, 30 Jul 2018 10:05:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KlDIXO+Mcgka1meWBOf1Pi4q8DWDxRJ3rhHYN1izPN4=; b=dYuWEFqHh0/obSFiqm96qPMxWN 8lVsDVBFpZBeSvp85/d+1U0xBYhoArFA1vsluoIckeuD2aPDZDYyGAgItnNi7J3oCQrngl4W6rerB guekHyL/wrO4CoFiJtzlfQ48j; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:42796 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fk9iv-0039Gw-Rh; Mon, 30 Jul 2018 10:04:37 -0500 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command References: <83effpubx5.fsf@gnu.org> <20180727075447.16243-1-jan.vrany@fit.cvut.cz> Date: Mon, 30 Jul 2018 15:05:00 -0000 In-Reply-To: <20180727075447.16243-1-jan.vrany@fit.cvut.cz> (Jan Vrany's message of "Fri, 27 Jul 2018 08:54:47 +0100") Message-ID: <87d0v469yy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00768.txt.bz2 >>>>> "Jan" == Jan Vrany writes: Jan> A CLI command "disassemble" allows use to specify a single Jan> address - in that case function surrounding that address is Jan> disassembled. Jan> high = parse_and_eval_address (oarg); Jan> end_seen = 1; Jan> break; Jan> + case ADDR_OPT: Jan> + addr = parse_and_eval_address (oarg); Jan> + addr_seen = 1; Jan> + break; The indentation looked slightly off here. It could just be how the patch looked here, but could you double-check just in case? Jan> + if (!((line_seen && file_seen && num_seen && !start_seen && !end_seen && !addr_seen) Jan> + || (line_seen && file_seen && !num_seen && !start_seen && !end_seen && !addr_seen) Jan> + || (!line_seen && !file_seen && !num_seen && start_seen && end_seen && !addr_seen) Jan> + || (!line_seen && !file_seen && !num_seen && !start_seen && !end_seen && addr_seen))) I suppose this ought to check for the case where either -s or -e is given along with -a. That seems like an error. This "if" made me laugh. Jan> + mi_gdb_test "112-data-disassemble -a \$pc -- 0" \ Jan> + "112\\^done,asm_insns=\\\[\{address=\"$hex\",func-name=\"main\",offset=\"$decimal\",inst=\".*\"\},\{address=\"$hex\",func-name=\"main\",offset=\"$decimal\",inst=\".*\"\}.*\]" \ Jan> + "data-disassemble function around pc assembly only" Jan> + Jan> + mi_gdb_test "112-data-disassemble -a callee4 -- 0" \ Jan> + "112\\^done,asm_insns=\\\[\{address=\"$hex\",func-name=\"callee4\",offset=\"$decimal\",inst=\".*\"\},\{address=\"$hex\",func-name=\"callee4\",offset=\"$decimal\",inst=\".*\"\}.*\]" \ Jan> + "data-disassemble function callee4 assembly only" Probably the second "112" should be "113". I don't know if you can reuse tokens or not, but it seems simple and safe not to. Thanks for doing this. It seems like a good addition to me. Tom