From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4843 invoked by alias); 20 Aug 2018 13:28:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4818 invoked by uid 89); 20 Aug 2018 13:28:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=warned, heard, Hx-languages-length:726, online X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.179.26) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Aug 2018 13:28:12 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 8ECFE400C3368 for ; Mon, 20 Aug 2018 07:31:46 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id rkE6frVcV79N3rkE6f7Zyp; Mon, 20 Aug 2018 08:28:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7n6XUnmDGgYe/hXAYXL7vSNoi5sXWfJgRPPcH9CR1+I=; b=kqjhMWGXKbFpvCSTP2tF6I7d/A 1iNxir2tLssOc39sf5OGfckr638H9IuVjhAo8oxBg7ZyGf1G2d6NYqPdLPhjB+ERAzrWAoq6NjSOD f29ADezup2yOPf94vNxa52B3q; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:44646 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1frkE6-003J7u-88; Mon, 20 Aug 2018 08:28:10 -0500 From: Tom Tromey To: Simon Marchi Cc: Keith Seitz , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 5/9] Change decode_compound_collector to use std::vector References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-6-keiths@redhat.com> <87pnypt086.fsf@tromey.com> <9675ef7a-9d3c-5dfb-3f56-e43d80eb02d5@redhat.com> Date: Mon, 20 Aug 2018 13:28:00 -0000 In-Reply-To: (Simon Marchi's message of "Sun, 19 Aug 2018 21:19:57 -0400") Message-ID: <87d0udqiah.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00462.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I've always read that it was bad to use std::move on a return value: Simon> https://diego.assencio.com/?index=f57f25fd5a187c70fc7f34fcf5374773 Simon> though in this case it seems like the right thing to do. It would be nice if gcc warned when a std::move was either redundant or recommended. Maybe this is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86981 ... I thought I heard that clang 8 has a new warning in this area but I couldn't find it anywhere online, only a hint here: https://bugzilla.mozilla.org/show_bug.cgi?id=1483985 So I'm not really sure how to file this. Tom