From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82176 invoked by alias); 28 Dec 2018 18:54:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82157 invoked by uid 89); 28 Dec 2018 18:54:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=colors X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.145.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Dec 2018 18:54:47 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id C40243363 for ; Fri, 28 Dec 2018 12:54:45 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cxHRgHUwVdnCecxHRgPdt3; Fri, 28 Dec 2018 12:54:45 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K2mNHTQSPut93lSJJTFqM1Q46cM87SxlvpSsFptsybA=; b=YRp/CcLhwQ6FeJ5Kd7BEJ8o+zp x5r2esWsJmFRMXXW/JJaHdqBmYl0fd0+q+uCILr035xFFjwubdZYu/WmMeYk6w7VFcgz41LXgpAO2 /g98PKarOD8ubLDE23xKBGxLQ; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:34086 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gcxHR-000pxU-H0; Fri, 28 Dec 2018 12:54:45 -0600 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 03/16] Introduce ui_file_style References: <20181128001435.12703-1-tom@tromey.com> <20181128001435.12703-4-tom@tromey.com> <20181224034018.GG5246@adacore.com> Date: Fri, 28 Dec 2018 18:54:00 -0000 In-Reply-To: <20181224034018.GG5246@adacore.com> (Joel Brobecker's message of "Mon, 24 Dec 2018 07:40:18 +0400") Message-ID: <87d0plo51n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00391.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> + /* Can't call this for a basic color. */ Joel> I am trying to understand this comment, as well as the corresponding Joel> comment describing this method (in ui-style.h): Joel> + This may not be called for simple colors or for the "NONE" Joel> + color. */ Joel> Does it look like you can, in fact, call this method on Joel> a simple color? Yeah. The naming was confusing here, so I have cleaned it up by renaming "enum simple_color" to "enum basic_color". You can call this method for any "simple" (scalar) color that isn't a basic color or NONE, simply because we don't have RGB values for these. >> + ui_file_style () >> + { >> + } Joel> Sorry for the obvious C++ question - Does this constructor means Joel> that the default constructor results in an object with undefined Joel> data? Or is that the same as... Joel> ui_file_style () = default; It's the same, I have changed the code to use the "= default" form. Joel> I think there might be a copy-pasto in the comment: N_READ -> BYTES? I fixed this. Tom