From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129137 invoked by alias); 15 Feb 2019 20:46:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128901 invoked by uid 89); 15 Feb 2019 20:46:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=fear, Hx-languages-length:1039 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.48.251) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Feb 2019 20:46:04 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway23.websitewelcome.com (Postfix) with ESMTP id E800016F21 for ; Fri, 15 Feb 2019 14:46:02 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ukN0gaX9kiQerukN0gpPNP; Fri, 15 Feb 2019 14:46:02 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=x0qsI1OzDfUXmxkp5v3+pWiYfRiVfw150uCdkB23dQs=; b=I41hjMVISMJIqmrkB+LwWJknMM W2dMuNJ6yjrt1cFF9WDYMrxudXLohWjhYFFQpZznFz32mzzBJYfujh5BIfvK6sMyiUlmVKaUZbw4w Is2ffk2xaNv0Pto7YfKsmpUjM; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:49228 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gukN0-003C13-Mm; Fri, 15 Feb 2019 14:46:02 -0600 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC] Sort #includes in gdb References: <87fttfmnpq.fsf@tromey.com> <20190127045818.GA15682@adacore.com> Date: Fri, 15 Feb 2019 20:46:00 -0000 In-Reply-To: <20190127045818.GA15682@adacore.com> (Joel Brobecker's message of "Sun, 27 Jan 2019 08:58:18 +0400") Message-ID: <87d0nsye46.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00260.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> It might be FUD on my part, but with C & C++, I've always been very Joel> nervous about changing the order of #include-s. This is because some Joel> headers sometimes define the same macros with different values, and Joel> so order can make a difference for those (without really knowing Joel> which is more correct, if any, and whether we are in fact getting Joel> the one that we should). And of course, this is all highly platform- Joel> dependent. Yeah, it's a concern; though I already pushed a series that fixes the fallout from the first draft of this series. Basically it was some minor latent bugs. I'll answer a bit more in reply to Pedro's note. Joel> I really like, however, the idea of overcoming that fear, and Joel> evaluate in practice what the real impact of order is. But since Joel> we are getting close to 8.3 branching, could we hold the actual Joel> puth until after the 8.3 branch is created? Definitely. Tom