From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67240 invoked by alias); 19 Mar 2019 20:18:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67215 invoked by uid 89); 19 Mar 2019 20:18:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.4.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Mar 2019 20:18:16 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway20.websitewelcome.com (Postfix) with ESMTP id D2744400D7F26 for ; Tue, 19 Mar 2019 15:18:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 6LBeh5ydFdnCe6LBehyGg9; Tue, 19 Mar 2019 15:18:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pfTbAg7u656yMvhh3NYgtJEBZXgv60RvyB/+6bf/ONc=; b=iKM8RZS7whu5Ov9+fya8gcs4Uh KFWWHdiEyH7UbGmQPPrkNh3CX+lNfkYp8U1mIC3gytiQvi5lpTIEFtQlebXyg7R0HuN//xGHxUxrk ILj5BM7Ha8FdSTvUZzXO2I70U; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:48740 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h6LBe-004Ftk-JO; Tue, 19 Mar 2019 15:18:14 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Richard Bunt Subject: Re: [PATCH 4/8] gdb/fortran: better types for components of complex numbers References: Date: Tue, 19 Mar 2019 20:18:00 -0000 In-Reply-To: (Andrew Burgess's message of "Mon, 18 Mar 2019 12:52:19 +0000") Message-ID: <87d0mmvcsa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00420.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> + case TYPE_CODE_FLT: Andrew> + /* In the case where the float was extracted from a complex number Andrew> + then the component part will not have a name set. Provide a Andrew> + suitable name here. Andrew> + Andrew> + QUESTION: Maybe we should be forcing the type name in the DWARF Andrew> + parser rather than fixing up the missing name at the last minute? Andrew> + I couldn't see any precedent for such fixing up though. */ I think that would be fine to do. Are the types nameless right now? Or does the compiler emit the incorrect name? Tom