From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60625 invoked by alias); 15 May 2019 01:38:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60614 invoked by uid 89); 15 May 2019 01:38:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*Ad:U*tom, H*RU:100.42.49.19, HX-Spam-Relays-External:100.42.49.19, HX-Spam-Relays-External:sk:cm16.we X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.184.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 May 2019 01:38:50 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id E088F400C8AC5 for ; Tue, 14 May 2019 19:58:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id QisbhNKbV4FKpQisbhlK0P; Tue, 14 May 2019 20:38:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9gHK+yB5OtBchCX/oL4SzsScsKMrrSjQYxvWpcn5BC8=; b=OgjrIHdGb2k1zNY7OCJKUskcMw TsOVJdeeh2MVCxQQPfVUNuk9eOZfJINcikXrR4BgpyG0hJyVsT5y4b7/djIrg7mcmiyS4aJZFdybB /iGq/gIwRwLUpYcEftkXE9fXQ; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:47304 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hQisb-002d3B-06; Tue, 14 May 2019 20:38:49 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: Tom Tromey , GDB Patches Subject: Re: [PATCH] Don't crash if dwarf_decode_macro_bytes's 'body' is NULL References: <871s124foc.fsf@tromey.com> <20190514205458.28796-1-sergiodj@redhat.com> <871s108z6j.fsf@tromey.com> <87wois4nhr.fsf@redhat.com> Date: Wed, 15 May 2019 01:38:00 -0000 In-Reply-To: <87wois4nhr.fsf@redhat.com> (Sergio Durigan Junior's message of "Tue, 14 May 2019 19:36:48 -0400") Message-ID: <87d0kkbioo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00343.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> Sorry, you're right, I left one extra argument there. I was testing the Sergio> patch on a VM, where I had everything correct, but then I made some Sergio> extra adjustments and forgot to remove the extra "line == 0 ? _("zero") Sergio> : _("non-zero")". Sergio> As for the filename, I was following what other complaints were doing. I think it's fine to just follow the other ones there. Sergio> But I also agree that having a filename would be best. What do you Sergio> think of: Sergio> complaint (_("debug info gives %s invalid macro definition " Sergio> "without body (corrupted?) at line %d" Sergio> "on file %s"), Sergio> at_commandline ? _("command-line") Sergio> : _("in-file"), Sergio> line, current_file->filename); Sergio> ? Works for me. This is ok, thanks. Tom