From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27656 invoked by alias); 9 Aug 2019 20:42:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27605 invoked by uid 89); 9 Aug 2019 20:42:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Aug 2019 20:42:30 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id A1F25F8600C for ; Fri, 9 Aug 2019 15:42:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id wBiXhouVe4FKpwBiXhwcni; Fri, 09 Aug 2019 15:42:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oaPvg4HdbDQmAxIgwyr+tNNET2qswQwZOeEBBai6OIs=; b=KWMTJsk20+TNBkaK4qGOctkr6a zPeHJ3+WxmdDelvwjEK3toPExDWngKSRMGcG1RAetozQ9oO/9qwRgMCwygVtMP833x2nXGleiE9j4 2sTdIYami1GIwY87YdKWf9C3H; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:40910 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hwBiX-000vp7-4c; Fri, 09 Aug 2019 15:42:29 -0500 From: Tom Tromey To: Pedro Franco de Carvalho Cc: gdb-patches@sourceware.org, tom@tromey.com, kevinb@redhat.com Subject: Re: [PATCH] Fix access to uninitialized variable in fill_in_stop_func References: <20190808104200.6a387ac8@f29-4.lan> <20190809191313.25200-1-pedromfc@linux.ibm.com> Date: Fri, 09 Aug 2019 20:42:00 -0000 In-Reply-To: <20190809191313.25200-1-pedromfc@linux.ibm.com> (Pedro Franco de Carvalho's message of "Fri, 9 Aug 2019 16:13:13 -0300") Message-ID: <87d0he3waz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00239.txt.bz2 >>>>> "Pedro" == Pedro Franco de Carvalho writes: Pedro> This patch changes find_pc_partial_function so that *block is set to Pedro> nullptr when it fails, so that fill_in_stop_func won't access an Pedro> uninitialized variable. Pedro> gdb/ChangeLog: Pedro> YYYY-MM-DD Pedro Franco de Carvalho Pedro> * blockframe.c (find_pc_partial_function): Set *block to nullptr Pedro> when the function fails. Thanks. This is ok. Tom