From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95644 invoked by alias); 9 Jan 2020 15:36:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95635 invoked by uid 89); 9 Jan 2020 15:36:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:611 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2020 15:36:11 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 1DEEB4D38 for ; Thu, 9 Jan 2020 09:34:37 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id pZpViloMBiJ43pZpVi3nAd; Thu, 09 Jan 2020 09:34:37 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oJJ8dnpTWZbL9yPi9fcNSrF7Q4TOAexAlP2tEWSLkPw=; b=EtegSY/IgBqU4To+5UwLFgh3J2 DNBAUEP1FUThIKaLGM4wCg4mv1pnV1MGrCkCBXi9eVCsxI12FICeHhmUmLLVLe9x2mALX612Ii/cG 6ybn5lIeycdzgmtNigYsiEzd9; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:40594 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ipZpU-001w7H-T9; Thu, 09 Jan 2020 08:34:36 -0700 From: Tom Tromey To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix/Update misc comments References: <20200106143620.2881-1-luis.machado@linaro.org> Date: Thu, 09 Jan 2020 15:36:00 -0000 In-Reply-To: <20200106143620.2881-1-luis.machado@linaro.org> (Luis Machado's message of "Mon, 6 Jan 2020 11:36:20 -0300") Message-ID: <87d0bsr6cz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00203.txt.bz2 >>>>> "Luis" == Luis Machado writes: Luis> How does it look? It seems reasonable to me. Probably Pedro should review it though. Luis> /* If this system does not support PT_STEP, a higher level Luis> - function will have called single_step() to transmute the step Luis> - request into a continue request (by setting breakpoints on Luis> + function will have called the appropriate functions to transmute the Luis> + step request into a continue request (by setting breakpoints on Is single_step not actually the function in question here? Tom