From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127289 invoked by alias); 11 Jan 2020 18:00:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126962 invoked by uid 89); 11 Jan 2020 18:00:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=unavailable version=3.3.1 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Jan 2020 18:00:40 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 1EDD0400C6EAD for ; Sat, 11 Jan 2020 10:54:17 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qK1hiqloaqNtvqK1hiTREP; Sat, 11 Jan 2020 10:54:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BQFZbCEU087xJWF01zbrlAlt6GUWEmUCy7avIvr0FLU=; b=A6JJIFNze49JNBGg1Ez/H7+PNb Vr5TxSPvA/Zc2WxyRuyVIXkjmI8SoYAAg33JuoWdovVkFb7+fmx1P+JT5j7JHiiwVfEdwV8+ed8s0 9qQQSfHwZg0s01OnCW2iW8/iP; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:49506 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iqK1g-003aC2-St; Sat, 11 Jan 2020 09:54:16 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic References: <20200110220027.26450-1-simon.marchi@efficios.com> Date: Sat, 11 Jan 2020 18:11:00 -0000 In-Reply-To: <20200110220027.26450-1-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 10 Jan 2020 17:00:20 -0500") Message-ID: <87d0bqexxj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00289.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> This is v2 of: Simon> https://sourceware.org/ml/gdb-patches/2019-11/msg00805.html Simon> Although a few patches of the original series were merged, since they Simon> were valid fixes in any case. I read through the series. I think this warning would be good to have, because it can help detect bugs. It's maybe mildly unfortunate that we have to have the first patch, but at the same time it's not that much noise in the end -- just an extra line (typically) near the end of a file. The other patches all seem desirable on their own terms. So, I think you should check it in. thanks, Tom From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36146 invoked by alias); 11 Jan 2020 17:29:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32873 invoked by uid 89); 11 Jan 2020 17:28:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=noise X-HELO: gateway21.websitewelcome.com Received: from Unknown (HELO gateway21.websitewelcome.com) (192.185.45.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Jan 2020 17:15:51 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 1EDD0400C6EAD for ; Sat, 11 Jan 2020 10:54:17 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qK1hiqloaqNtvqK1hiTREP; Sat, 11 Jan 2020 10:54:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BQFZbCEU087xJWF01zbrlAlt6GUWEmUCy7avIvr0FLU=; b=A6JJIFNze49JNBGg1Ez/H7+PNb Vr5TxSPvA/Zc2WxyRuyVIXkjmI8SoYAAg33JuoWdovVkFb7+fmx1P+JT5j7JHiiwVfEdwV8+ed8s0 9qQQSfHwZg0s01OnCW2iW8/iP; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:49506 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iqK1g-003aC2-St; Sat, 11 Jan 2020 09:54:16 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic References: <20200110220027.26450-1-simon.marchi@efficios.com> Date: Sat, 11 Jan 2020 17:29:00 -0000 In-Reply-To: <20200110220027.26450-1-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 10 Jan 2020 17:00:20 -0500") Message-ID: <87d0bqexxj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00288.txt.bz2 Message-ID: <20200111172900.GuzzKTsRyyQuTv7pQ4vtfXPEXHkcITWRZyZi3IFkJYQ@z> >>>>> "Simon" == Simon Marchi writes: Simon> This is v2 of: Simon> https://sourceware.org/ml/gdb-patches/2019-11/msg00805.html Simon> Although a few patches of the original series were merged, since they Simon> were valid fixes in any case. I read through the series. I think this warning would be good to have, because it can help detect bugs. It's maybe mildly unfortunate that we have to have the first patch, but at the same time it's not that much noise in the end -- just an extra line (typically) near the end of a file. The other patches all seem desirable on their own terms. So, I think you should check it in. thanks, Tom