From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb: fix duplicate test names in gdb.base/break.exp
Date: Wed, 29 Apr 2020 14:14:37 -0600 [thread overview]
Message-ID: <87d07q59si.fsf@tromey.com> (raw)
In-Reply-To: <20200429145211.3437388-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Wed, 29 Apr 2020 10:52:11 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> These test names are duplicated:
Simon> 2 PASS: gdb.base/break.exp: set breakpoint via non-integer convenience variable disallowed
Simon> 2 PASS: gdb.base/break.exp: set convenience variable $foo to 81.5
Simon> Wrap them with `with_test_prefix`. I've actually wrapped a bit more
Simon> tests that are related, I think it helps to give the test names a bit
Simon> more context. The modified test names are:
Seems like a good idea to me.
Thanks.
Tom
next prev parent reply other threads:[~2020-04-29 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 14:52 Simon Marchi
2020-04-29 20:14 ` Tom Tromey [this message]
2020-04-29 20:35 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d07q59si.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox